CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Speed up rate limiting test in test_external.

Browse Source 
Patches out the `time.sleep` and mocks the `time.time` to one second
ahead.

Resolves #2239.
This commit is contained in:
Jason Le 2016-12-08 17:08:39 -05:00 committed by Tim Abbott
parent 4eb6adf547
commit 67f28fe62d
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
zerver/tests/test_external.py
View File

@ -18,7 +18,6 @@ from zerver.lib.test_classes import (
ZulipTestCase,
)
from zerver.models import get_user_profile_by_email
from zerver.lib.test_runner import slow
import DNS
import mock
@ -100,7 +99,6 @@ class RateLimitTests(ZulipTestCase):
newlimit = int(result['X-RateLimit-Remaining'])
self.assertEqual(limit, newlimit + 1)
@slow('has to sleep to work')
def test_hit_ratelimits(self):
# type: () -> None
email = "cordelia@zulip.com"
@ -120,8 +118,7 @@ class RateLimitTests(ZulipTestCase):
# We actually wait a second here, rather than force-clearing our history,
# to make sure the rate-limiting code automatically forgives a user
# after some time has passed.
time.sleep(1)
with mock.patch('time.time', return_value=(time.time() + 1)):
result = self.send_api_message(email, "Good message")
result = self.send_api_message(email, "Good message")
self.assert_json_success(result)
self.assert_json_success(result)