From 65ed20469ebb686504d9a04036bfc175c23660ca Mon Sep 17 00:00:00 2001
From: Scott Feeney <scott@zulip.com>
Date: Fri, 6 Sep 2013 17:25:43 -0400
Subject: [PATCH] Split out get_subscribers method on backend

(imported from commit b5941ff90bbf5b31a9fa31aa83e5d1856d483dcc)
---
 zerver/lib/actions.py    | 43 ++++++++++++++++++++++++++++++++++++++++
 zerver/views/__init__.py | 24 ++++------------------
 2 files changed, 47 insertions(+), 20 deletions(-)

diff --git a/zerver/lib/actions.py b/zerver/lib/actions.py
index 5029c8d660..cca895cdd4 100644
--- a/zerver/lib/actions.py
+++ b/zerver/lib/actions.py
@@ -558,6 +558,49 @@ def get_subscription(stream_name, user_profile):
     return Subscription.objects.get(user_profile=user_profile,
                                     recipient=recipient, active=True)
 
+def get_subscribers(stream, realm=None, requesting_user=None):
+    """ Get the subscribers list for a stream, raising a JsonableError if:
+        * No stream by that name exists in the realm.
+        * The realm is MIT and the stream is not invite only.
+        * The stream is invite only, requesting_user is passed, and that user
+          does not subscribe to the stream.
+
+    'stream' can either be a string representing a stream name, or a Stream
+    object. If it's a Stream object, 'realm' is optional.
+    """
+
+    try:
+        # If a Stream object was passed, get the realm from that.
+        realm = stream.realm
+    except AttributeError:
+        # Assume a stream name was passed. Get the corresponding Stream object.
+        stream_name = stream
+        stream = get_stream(stream_name, realm)
+        if stream is None:
+            raise JsonableError("Stream does not exist: %s" % stream_name)
+
+    # requesting_user, if passed, shouldn't be on a different realm.
+    if requesting_user is not None and requesting_user.realm != realm:
+        raise ValidationError("Requesting user not on given realm")
+
+    if realm.domain == "mit.edu" and not stream.invite_only:
+        raise JsonableError("You cannot get subscribers for public streams in this realm")
+
+    if (requesting_user is not None and stream.invite_only
+            and not subscribed_to_stream(requesting_user, stream)):
+        raise JsonableError("Unable to retrieve subscribers for invite-only stream")
+
+    # Note that non-active users may still have "active" subscriptions, because we
+    # want to be able to easily reactivate them with their old subscriptions.  This
+    # is why the query here has to look at the UserProfile.is_active flag.
+    subscriptions = Subscription.objects.filter(recipient__type=Recipient.STREAM,
+                                                recipient__type_id=stream.id,
+                                                user_profile__is_active=True,
+                                                active=True).select_related()
+
+    return [subscription.user_profile for subscription in subscriptions]
+
+
 def set_stream_color(user_profile, stream_name, color=None):
     subscription = get_subscription(stream_name, user_profile)
     if not color:
diff --git a/zerver/views/__init__.py b/zerver/views/__init__.py
index 5f54a62090..0db0cc96e3 100644
--- a/zerver/views/__init__.py
+++ b/zerver/views/__init__.py
@@ -36,7 +36,7 @@ from zerver.lib.actions import do_remove_subscription, bulk_remove_subscriptions
     do_update_onboarding_steps, do_update_message, internal_prep_message, \
     do_send_messages, do_add_subscription, get_default_subs, do_deactivate, \
     user_email_is_unique, do_invite_users, do_refer_friend, compute_mit_user_fullname, \
-    do_add_alert_words, do_remove_alert_words, do_set_alert_words
+    do_add_alert_words, do_remove_alert_words, do_set_alert_words, get_subscribers
 from zerver.lib.create_user import random_api_key
 from zerver.forms import RegistrationForm, HomepageForm, ToSForm, CreateBotForm, \
     is_inactive, isnt_mit, not_mit_mailing_list
@@ -1612,26 +1612,10 @@ def json_upload_file(request, user_profile):
 
 @has_request_variables
 def get_subscribers_backend(request, user_profile, stream_name=REQ('stream')):
-    stream = get_stream(stream_name, user_profile.realm)
-    if stream is None:
-        return json_error("Stream does not exist: %s" % stream_name)
+    subscribers = get_subscribers(stream_name, user_profile.realm, user_profile)
 
-    if user_profile.realm.domain == "mit.edu" and not stream.invite_only:
-        return json_error("You cannot get subscribers for public streams in this realm")
-
-    if stream.invite_only and not subscribed_to_stream(user_profile, stream):
-        return json_error("Unable to retrieve subscribers for invite-only stream")
-
-    # Note that non-active users may still have "active" subscriptions, because we
-    # want to be able to easily reactivate them with their old subscriptions.  This
-    # is why the query here has to look at the UserProfile.is_active flag.
-    subscriptions = Subscription.objects.filter(recipient__type=Recipient.STREAM,
-                                                recipient__type_id=stream.id,
-                                                user_profile__is_active=True,
-                                                active=True).select_related()
-
-    return json_success({'subscribers': [subscription.user_profile.email
-                                         for subscription in subscriptions]})
+    return json_success({'subscribers': [subscriber.email
+                                         for subscriber in subscribers]})
 
 @authenticated_json_post_view
 @has_request_variables