CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-30 21:11:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't show the out of view banner for messages further down.

Browse Source 
This makes the notification slightly more conservative as we do our
initial roll out. In particular, it avoids cases like being notified
when you are almost at the bottom of your feed for a message in your
narrow.

(imported from commit 9c834b1c344d8c429de92fb3512f32494fc02379)
This commit is contained in:
Jessica McKellar 2013-11-19 17:17:31 -05:00
parent 376a467d89
commit 657e1f1f9a
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/notifications.js
View File

@ -409,14 +409,6 @@ exports.possibly_notify_new_messages_outside_viewport = function (messages) {
note = "You sent a message outside the current narrow.";
link_class = "compose_notification_narrow_by_subject";
link_text = "Narrow to " + get_message_header(message);
}
else if (viewport.is_below_visible_bottom(row.offset().top) && !narrow.narrowed_by_reply()){
// offscreen because it's too far down.
// offer scroll to message link.
note = "Your recently sent message is";
link_class = "compose_notification_scroll_to_message";
link_text = "further down";
} else {
// return with _.each is like continue for normal for loops.
return;