CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-03 21:10:12 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

navbar: Extract mouse event handlers to separate function.

Browse Source 
It's best to separate these in order to simplify the "build_tab_bar"
function. We also correct a comment about the "search_exit" click
handler being for the searchbar.
This commit is contained in:
YashRE42 2020-05-16 23:02:30 +05:30 committed by Tim Abbott
parent d9b503278b
commit 59be2dcc18
1 changed files with 34 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
static/js/tab_bar.js
View File

@ -68,6 +68,38 @@ function append_and_display_title_area(tab_bar_data) {
}
}
function bind_title_area_handlers() {
$("#tab_list span:nth-last-child(2)").on("click", function (e) {
if (document.getSelection().type === "Range") {
// Allow copy/paste to work normally without interference.
return;
}
// Let links behave normally, ie, do nothing if <a>
if ($(e.target).closest("a").length === 0) {
exports.open_search_bar_and_close_narrow_description();
search.initiate_search();
e.preventDefault();
e.stopPropagation();
}
});
const color = $(".search_closed").css("color");
const night_mode_color = $(".nightmode .closed_icon").css("color");
// make sure that hover plays nicely with whether search is being
// opened or not.
$(".narrow_description > a").hover(function () {
if (night_mode_color) {
$(".search_closed").css("color", night_mode_color);
} else {
$(".search_closed").css("color", color);
}
}, function () {
$(".search_closed").css("color", "");
});
}
function build_tab_bar(filter) {
// This makes sure we don't waste time appending tab_bar on a template where it's never used
if (filter && !filter.is_common_narrow()) {
@ -75,44 +107,7 @@ function build_tab_bar(filter) {
} else {
const tab_bar_data = make_tab_data(filter);
append_and_display_title_area(tab_bar_data);
$(".search_closed").on("click", function (e) {
exports.open_search_bar_and_close_narrow_description();
search.initiate_search();
e.preventDefault();
e.stopPropagation();
});
$("#tab_list span:nth-last-child(2)").on("click", function (e) {
if (document.getSelection().type === "Range") {
// Allow copy/paste to work normally without interference.
return;
}
// Let links behave normally, ie, do nothing if <a>
if ($(e.target).closest("a").length === 0) {
exports.open_search_bar_and_close_narrow_description();
search.initiate_search();
e.preventDefault();
e.stopPropagation();
}
});
const color = $(".search_closed").css("color");
const night_mode_color = $(".nightmode .closed_icon").css("color");
// make sure that hover plays nicely with whether search is being
// opened or not.
$(".narrow_description > a").hover(function () {
if (night_mode_color) {
$(".search_closed").css("color", night_mode_color);
} else {
$(".search_closed").css("color", color);
}
}, function () {
$(".search_closed").css("color", "");
});
bind_title_area_handlers();
exports.close_search_bar_and_open_narrow_description();
}
}
@ -158,7 +153,7 @@ exports.initialize = function () {
const filter = narrow_state.filter();
build_tab_bar(filter);
// register navbar click handlers
// register searchbar click handler
$('#search_exit').on("click", function (e) {
tab_bar.exit_search();
e.preventDefault();