CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-21 21:32:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

settings: Revert checkmark icon to fontawesome and checkbox-green.

Browse Source 
In 7b8da9b we have introduced some other checkmark icons
which aren't necessary as old icons still make sense there.

So removing them as they don't add any extra value.

Fixes: #8995.
This commit is contained in:
Shubham Dhama 2018-04-12 23:25:17 +05:30 committed by Tim Abbott
parent 250a036ff8
commit 50545a3571
5 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
static/images/icon-checkbox-green.svg
View File

@ -1,5 +0,0 @@
<svg fill="#59a687" height="1000px" width="665.7999877929688px" xmlns="http://www.w3.org/2000/svg">
<g>
<path d="M248 850c-22.667 0 -41.333 -9.333 -56 -28c0 0 -180 -236 -180 -236c-10.667 -16 -14.667 -33.333 -12 -52c2.667 -18.667 11.333 -34 26 -46c14.667 -12 31.667 -16.667 51 -14c19.333 2.667 35 12 47 28c0 0 118 154 118 154c0 0 296 -474 296 -474c10.667 -16 25 -26 43 -30c18 -4 35.667 -1.333 53 8c16 10.667 26 25 30 43c4 18 1.333 35.667 -8 53c0 0 -350 560 -350 560c-13.333 21.333 -32 32 -56 32c0 0 -2 2 -2 2" />
</g>
</svg>
Side by Side

Before

Width:  |  Height:  |  Size: 532 B

5
static/images/icon-checkbox-white.svg
View File

@ -1,5 +0,0 @@
<svg fill="#FFFFFF" height="1000px" width="665.7999877929688px" xmlns="http://www.w3.org/2000/svg">
<g>
<path d="M248 850c-22.667 0 -41.333 -9.333 -56 -28c0 0 -180 -236 -180 -236c-10.667 -16 -14.667 -33.333 -12 -52c2.667 -18.667 11.333 -34 26 -46c14.667 -12 31.667 -16.667 51 -14c19.333 2.667 35 12 47 28c0 0 118 154 118 154c0 0 296 -474 296 -474c10.667 -16 25 -26 43 -30c18 -4 35.667 -1.333 53 8c16 10.667 26 25 30 43c4 18 1.333 35.667 -8 53c0 0 -350 560 -350 560c-13.333 21.333 -32 32 -56 32c0 0 -2 2 -2 2" />
</g>
</svg>
Side by Side

Before

Width:  |  Height:  |  Size: 532 B

4
static/js/settings_ui.js
View File

@ -4,9 +4,9 @@ var exports = {};
exports.display_checkmark = function ($elem) {
var check_mark = document.createElement("img");
check_mark.src = "/static/images/icon-checkbox-green.svg";
check_mark.src = "/static/images/checkbox-green.svg";
$elem.prepend(check_mark);
$(check_mark).css("width", "10px");
$(check_mark).css("width", "13px");
};
exports.strings = {};

6
static/styles/settings.css
View File

@ -397,9 +397,9 @@ input[type=checkbox] + .inline-block {
}
#settings_page .icon-button.primary .icon-button-icon {
width: 10px;
margin-bottom: 2px;
margin-right: 3px;
font-size: 15px;
font-weight: lighter;
color: white;
}
#settings_page .icon-button .icon-button-text {

2
static/templates/settings/settings-save-discard-widget.handlebars
View File

@ -3,7 +3,7 @@
<div class="input-group organization-submission subsection-changes-save">
<div class="icon-button button primary save-button" type="button" id="org-submit-{{section_name}}" data-status="save">
<span class="fa fa-spinner fa-spin icon-button-loading"></span>
<img class="icon-button-icon" src="static/images/icon-checkbox-white.svg" />
<span class="fa fa-check icon-button-icon"></span>
<span class="icon-button-text">
{{t 'Save changes' }}
</span>