CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-12 21:04:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

lightbox: Index asset_map entries to use message_id.

Browse Source 
This commit indexes the `asset_map` cache entries with message_id
so that it can be helpful to invalidate cache of a certain message
when its content is edited.

This is a preparatory commit to #21311
This commit is contained in:
Rohan Gudimetla 2025-06-14 04:07:00 +05:30 committed by Tim Abbott
parent 0b2cb835f5
commit 4c69cf13f1
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
web/src/lightbox.ts
View File

@ -34,9 +34,10 @@ type Media = {
let is_open = false;
// The asset map is a map of all retrieved images and YouTube videos that are memoized instead of
// being looked up multiple times. It is keyed by the asset's "canonical URL," which is likely the
// `src` used in the message feed, but for thumbnailed images is the full-resolution original URL.
const asset_map = new Map<string, Media>();
// being looked up multiple times. It is keyed by the message id with each value being the
// message's assets map keyed by the asset's "canonical URL," which is likely the `src` used in
// the message feed, but for thumbnailed images is the full-resolution original URL.
const asset_map = new Map<number, Map<string, Media>>();
export class PanZoomControl {
// Class for both initializing and controlling the
@ -479,10 +480,11 @@ function supports_heic(): boolean {
// retrieve the metadata from the DOM and store into the asset_map.
export function parse_media_data(media: HTMLMediaElement | HTMLImageElement): Media {
const message_id = rows.get_message_id(media);
const canonical_url = canonical_url_of_media(media);
if (asset_map.has(canonical_url)) {
if (asset_map.has(message_id) && asset_map.get(message_id)?.has(canonical_url)) {
// Use the cached value
const payload = asset_map.get(canonical_url);
const payload = asset_map.get(message_id)!.get(canonical_url);
assert(payload !== undefined);
return payload;
}
@ -561,7 +563,6 @@ export function parse_media_data(media: HTMLMediaElement | HTMLImageElement): Me
if (is_compose_preview_media) {
sender_full_name = people.my_full_name();
} else {
const message_id = rows.get_message_id(media);
const message = message_store.get(message_id);
if (message === undefined) {
blueslip.error("Lightbox for unknown message", {message_id});
@ -582,7 +583,10 @@ export function parse_media_data(media: HTMLMediaElement | HTMLImageElement): Me
};
if (!is_loading_placeholder && canonical_url !== "") {
asset_map.set(canonical_url, payload);
if (!asset_map.has(message_id)) {
asset_map.set(message_id, new Map<string, Media>());
}
asset_map.get(message_id)!.set(canonical_url, payload);
}
return payload;
}