CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-21 21:32:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

stream_sidebar: Clean up use of ambiguously named data-id.

Browse Source 
We prefer to specify the type of data objects wherever possible.
This commit is contained in:
Tim Abbott 2017-08-16 16:28:32 -07:00
parent 78d9fcd23a
commit 4acd7595cd
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/stream_popover.js
View File

@ -99,7 +99,7 @@ function build_stream_popover(e) {
$(elt).popover("show");
var data_id = stream_data.get_sub(stream).stream_id;
var popover = $('.streams_popover[data-id=' + data_id + ']');
var popover = $('.streams_popover[data-stream-id=' + data_id + ']');
update_spectrum(popover, function (colorpicker) {
colorpicker.spectrum(stream_color.sidebar_popover_colorpicker_options);

2
static/templates/stream_sidebar_actions.handlebars
View File

@ -1,5 +1,5 @@
{{! Contents of the "stream actions" popup }}
<ul class="nav nav-list streams_popover" data-id="{{ stream.stream_id }}" data-name="{{ stream.name }}">
<ul class="nav nav-list streams_popover" data-stream-id="{{ stream.stream_id }}" data-name="{{ stream.name }}">
<li>
<a class="open_stream_settings">
<i class="icon-vector-cog"></i>