From 48dae579b249bfcb2dd9bc53cee2b4d559841cda Mon Sep 17 00:00:00 2001 From: Sayam Samal Date: Fri, 28 Feb 2025 13:16:03 +0530 Subject: [PATCH] alerts: Remove --base-font-size-px and allow font-size to be inherited. This is a follow-up commit to d1de4457dc34c4297a3f0fcffc08425ca66b9a68, which had set the font-size for the alert popups to --base-font-size-px. This removes that line of code, as it was pointed out by Tim Abbott that the web/styles/alerts.css file was also being shared with portico through the web/src/bundles/common.ts bundle, but the --base-font-size-px variable doesn't exist there. Removing the font-size property from the alert box doesn't affect its styling since it still inherits the `--base-font-size-px` from the body in the Zulip Web App. --- web/styles/alerts.css | 2 -- 1 file changed, 2 deletions(-) diff --git a/web/styles/alerts.css b/web/styles/alerts.css index cdb3fc8547..162eb2a67d 100644 --- a/web/styles/alerts.css +++ b/web/styles/alerts.css @@ -150,8 +150,6 @@ .alert { @extend .alert-animations; - /* Use --base-font-size-px to prevent any chaining on the font size */ - font-size: var(--base-font-size-px); border-radius: 4px; background-color: hsl(0deg 0% 100%);