CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-18 21:04:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

recent_view: Fix error on initial fetch being all muted messages.

Browse Source 
If the initial fetch pre #29740 fetches all muted messages we don't
have any messages in all message list and hence query for
oldest message is undefined.

This results in us trying to render oldest_message_timestamp
with its value as infinity.

To fix it, we include muted messages in our search for oldest
message in the list and if we still cannot find one, we wait
for the next fetch.
This commit is contained in:
Aman Agrawal 2024-05-19 04:14:40 +00:00 committed by Tim Abbott
parent c798d192dc
commit 44fa39c4c4
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/src/recent_view_ui.ts
View File

@ -175,9 +175,22 @@ let oldest_message_timestamp = Number.POSITIVE_INFINITY;
function set_oldest_message_date(msg_list_data: MessageListData): void {
const has_found_oldest = msg_list_data.fetch_status.has_found_oldest();
const has_found_newest = msg_list_data.fetch_status.has_found_newest();
const oldest_message_in_data = msg_list_data.first_including_muted();
if (oldest_message_in_data) {
oldest_message_timestamp = Math.min(
oldest_message_in_data.timestamp,
oldest_message_timestamp,
);
}
const first_message_timestamp = msg_list_data.first()?.timestamp ?? Number.POSITIVE_INFINITY;
oldest_message_timestamp = Math.min(first_message_timestamp, oldest_message_timestamp);
if (oldest_message_timestamp === Number.POSITIVE_INFINITY && !has_found_oldest) {
// This should only happen either very early in loading the
// message list, since it requires the msg_list_data object
// being empty, without having server confirmation that's the
// case. Wait for server data to do anything in that
// situation.
return;
}
if (has_found_oldest) {
loading_state = ALL_MESSAGES_LOADED;