CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

subs: combine some settings show handlers.

Browse Source
This commit is contained in:
Tim Abbott 2016-10-27 22:22:28 -07:00
parent 3fd94cc58a
commit 426f2b0405
1 changed files with 23 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
static/js/subs.js
View File

@ -339,6 +339,29 @@ function show_subscription_settings(sub_row) {
return item.email;
}
});
var colorpicker = sub_row.find('.colorpicker');
var color = stream_data.get_color(sub_row.find('.subscription_name').text());
stream_color.set_colorpicker_color(colorpicker, color);
// To figure out the worst case for an expanded row's height, we do some math:
// .subscriber_list_container max-height,
// .subscriber_list_settings,
// .regular_subscription_settings
// .subscription_header line-height,
// .subscription_header padding
var expanded_row_size = 200 + 30 + 100 + 30 + 5;
var cover = sub_row.offset().top + expanded_row_size -
viewport.height() + viewport.scrollTop();
if (cover > 0) {
$('.app').animate({
scrollTop: viewport.scrollTop() + cover + 5
});
}
// Make all inputs have a default tabindex
sub_row.find('.subscription_settings :input').removeAttr('tabindex');
}
exports.mark_subscribed = function (stream_name, attrs) {
@ -900,32 +923,6 @@ $(function () {
$('#empty_narrow_message').show();
});
$("#subscriptions_table").on("show", ".subscription_settings", function (e) {
var sub_row = $(e.target).closest('.subscription_row');
var colorpicker = sub_row.find('.colorpicker');
var color = stream_data.get_color(sub_row.find('.subscription_name').text());
stream_color.set_colorpicker_color(colorpicker, color);
// To figure out the worst case for an expanded row's height, we do some math:
// .subscriber_list_container max-height,
// .subscriber_list_settings,
// .regular_subscription_settings
// .subscription_header line-height,
// .subscription_header padding
var expanded_row_size = 200 + 30 + 100 + 30 + 5;
var cover = sub_row.offset().top + expanded_row_size -
viewport.height() + viewport.scrollTop();
if (cover > 0) {
$('.app').animate({
scrollTop: viewport.scrollTop() + cover + 5
});
}
// Make all inputs have a default tabindex
sub_row.find('.subscription_settings :input').removeAttr('tabindex');
});
$("#subscriptions_table").on("hide", ".subscription_settings", function (e) {
var sub_row = $(e.target).closest('.subscription_row');