From 40b4da8f582516e1ecea273faefe7e433f0d6ec6 Mon Sep 17 00:00:00 2001 From: Zixuan James Li Date: Tue, 14 Jun 2022 22:02:27 -0400 Subject: [PATCH] emoji: Add none checks for uploaded file name. Signed-off-by: Zixuan James Li --- zerver/lib/upload.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zerver/lib/upload.py b/zerver/lib/upload.py index bcbee4496d..a95338a201 100644 --- a/zerver/lib/upload.py +++ b/zerver/lib/upload.py @@ -377,6 +377,7 @@ def check_upload_within_quota(realm: Realm, uploaded_file_size: int) -> None: def get_file_info(request: HttpRequest, user_file: File) -> Tuple[str, int, Optional[str]]: uploaded_file_name = user_file.name + assert uploaded_file_name is not None content_type = request.GET.get("mimetype") if content_type is None: guessed_type = guess_type(uploaded_file_name)[0] @@ -1201,6 +1202,7 @@ def handle_reupload_emojis_event(realm: Realm, logger: logging.Logger) -> None: for realm_emoji in query: logger.info("Processing emoji %s", realm_emoji.id) emoji_filename = realm_emoji.file_name + assert emoji_filename is not None emoji_url = get_emoji_url(emoji_filename, realm_emoji.realm_id) if emoji_url.startswith("/"): emoji_url = urljoin(realm_emoji.realm.uri, emoji_url)