CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-09 21:21:47 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

maybe_send_to_registration: Remove password_required arg.

Browse Source 
This argument was added with the default incorrectly set to `True` in
bb0eb76bf3 - despite
`maybe_send_to_registration` only ever being called in production code
in a single place, with `password_required=False` explicitly. And then
it just got carried forward through refactors.

`maybe_send_to_registration` was/is also called twice in tests, falling
back to the default, but the `password_required` value is irrelevant to
the tests - and if anything letting it use the `True` has been wrong,
due to not matching how this function is actually used.
This commit is contained in:
Mateusz Mandera 2023-03-12 20:04:32 +01:00 committed by Alex Vandiver
parent 28c5c64b8d
commit 3ed2a30e01
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/views/auth.py
View File

@ -154,7 +154,6 @@ def maybe_send_to_registration(
mobile_flow_otp: Optional[str] = None,
desktop_flow_otp: Optional[str] = None,
is_signup: bool = False,
password_required: bool = True,
multiuse_object_key: str = "",
full_name_validated: bool = False,
) -> HttpResponse:
@ -241,13 +240,13 @@ def maybe_send_to_registration(
except PreregistrationUser.DoesNotExist:
existing_prereg_user = None
# password_required and full_name data passed here as argument should take precedence
# full_name data passed here as argument should take precedence
# over the defaults with which the existing PreregistrationUser that we've just fetched
# was created.
prereg_user = create_preregistration_user(
email,
realm,
password_required=password_required,
password_required=False,
full_name=full_name,
full_name_validated=full_name_validated,
multiuse_invite=multiuse_obj,
@ -316,7 +315,6 @@ def register_remote_user(request: HttpRequest, result: ExternalAuthResult) -> Ht
if key not in kwargs_to_pass:
kwargs.pop(key, None)
kwargs["password_required"] = False
return maybe_send_to_registration(request, **kwargs)