From 3b9c726fc69fcd98caab3751c2570dfd59a2db5e Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Thu, 29 Oct 2020 15:55:09 -0700 Subject: [PATCH] outgoing_webhook: Avoid logging a bytes string. This fixes the new assertLogs() tests failing in CI; we fixed the weird use of bytes in the test, but not in the runtime code. --- zerver/lib/outgoing_webhook.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/lib/outgoing_webhook.py b/zerver/lib/outgoing_webhook.py index 379ce727ad..78f82c1333 100644 --- a/zerver/lib/outgoing_webhook.py +++ b/zerver/lib/outgoing_webhook.py @@ -310,7 +310,7 @@ def do_rest_call(base_url: str, "%(response)s\"", {'message_url': get_message_url(event), 'status_code': response.status_code, - 'response': response.content}) + 'response': response.content.decode()}) failure_message = f"Third party responded with {response.status_code}" fail_with_message(event, failure_message) notify_bot_owner(event, response.status_code, response.content)