From 39efe4e214ea47b20b6be96fbbb9ef4c6de485c4 Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Wed, 19 Nov 2025 14:54:58 +0530
Subject: [PATCH] css: Fix "line-height: inherit" values for textarea.

Instead of using "line-height: inherit" we set the line-height
property to actual value which will be a less mysterious value
than using inherit. We now set this to "--base-line-height-unitless"
which changes the line-height value as previously it was
inherited from body which is set to maximum of the base line
height value and the fixed legacy value of 1.43.

This means that the line-height of textarea will now be set to
the configured line spacing value by user while previously
it was not set to the line spacing values less than the default
value as it was inherited from the value set to body.
---
 web/styles/compose.css            | 2 +-
 web/styles/message_row.css        | 2 +-
 web/styles/scheduled_messages.css | 2 +-
 web/styles/settings.css           | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/web/styles/compose.css b/web/styles/compose.css
index b103c43ab2..1d3fddf568 100644
--- a/web/styles/compose.css
+++ b/web/styles/compose.css
@@ -1079,7 +1079,7 @@ textarea.new_message_textarea {
     box-shadow: none;
 
     font-size: 1em;
-    line-height: inherit;
+    line-height: var(--base-line-height-unitless);
     font-family: "Source Sans 3 VF", sans-serif;
 
     &:focus {
diff --git a/web/styles/message_row.css b/web/styles/message_row.css
index f0e98366fb..9fa9807250 100644
--- a/web/styles/message_row.css
+++ b/web/styles/message_row.css
@@ -865,7 +865,7 @@
     box-shadow: none;
 
     font-size: 1em;
-    line-height: inherit;
+    line-height: var(--base-line-height-unitless);
     font-family: "Source Sans 3 VF", sans-serif;
 
     &:focus {
diff --git a/web/styles/scheduled_messages.css b/web/styles/scheduled_messages.css
index 2f7a83ddcf..b6fbfad5c2 100644
--- a/web/styles/scheduled_messages.css
+++ b/web/styles/scheduled_messages.css
@@ -31,6 +31,6 @@
     background-color: var(--background-color-textarea);
 
     font-size: 1em;
-    line-height: inherit;
+    line-height: var(--base-line-height-unitless);
     font-family: "Source Sans 3 VF", sans-serif;
 }
diff --git a/web/styles/settings.css b/web/styles/settings.css
index bdfa58690a..55423e635d 100644
--- a/web/styles/settings.css
+++ b/web/styles/settings.css
@@ -1782,7 +1782,7 @@ label.preferences-radio-choice-label {
         box-shadow linear 0.2s;
 
     font-size: 1em;
-    line-height: inherit;
+    line-height: var(--base-line-height-unitless);
     font-family: "Source Sans 3 VF", sans-serif;
 
     &:focus {