CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-06-24 21:08:25 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

left sidebar: Make Views label visible for spectators.

Browse Source 
We don't include the toggle functionality, to avoid needing to design
what a collapsed Views thing would look like.

Fixes #30324.
This commit is contained in:
opmkumar 2024-06-18 15:05:02 +05:30 committed by Tim Abbott
parent 6fe15626ae
commit 30f65e5e2d
4 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/left_sidebar_navigation_area.ts
View File

@ -130,6 +130,12 @@ export function handle_narrow_activated(filter: Filter): void {
function toggle_condensed_navigation_area(): void {
const $views_label_container = $("#views-label-container");
const $views_label_icon = $("#toggle-top-left-navigation-area-icon");
if (page_params.is_spectator) {
// We don't support collapsing VIEWS for spectators, so exit early.
return;
}
if ($views_label_container.hasClass("showing-expanded-navigation")) {
// Toggle into the condensed state
$views_label_container.addClass("showing-condensed-navigation");

1
web/src/sidebar_ui.ts
View File

@ -219,6 +219,7 @@ export function initialize_left_sidebar(): void {
is_recent_view_home_view:
user_settings.web_home_view === settings_config.web_home_view_values.recent_topics.code,
hide_unread_counts: settings_data.should_mask_unread_count(false),
is_spectator: page_params.is_spectator,
});
$("#left-sidebar-container").html(rendered_sidebar);

5
web/styles/left_sidebar.css
View File

@ -812,6 +812,11 @@ li.top_left_scheduled_messages {
}
}
/* Remove the cursor: pointer property of Views label for the spectators. */
&.remove-pointer-for-spectator {
cursor: default;
}
#toggle-top-left-navigation-area-icon {
grid-area: starting-anchor-element;
}

4
web/templates/left_sidebar.hbs
View File

@ -1,7 +1,7 @@
<div class="left-sidebar" id="left-sidebar" role="navigation">
<div id="left-sidebar-navigation-area" class="left-sidebar-navigation-area">
<div id="views-label-container" class="showing-expanded-navigation hidden-for-spectators">
<i id="toggle-top-left-navigation-area-icon" class="fa fa-sm fa-caret-down views-tooltip-target" aria-hidden="true"></i>
<div id="views-label-container" class="showing-expanded-navigation {{#if is_spectator}}remove-pointer-for-spectator{{/if}}">
<i id="toggle-top-left-navigation-area-icon" class="fa fa-sm fa-caret-down views-tooltip-target hidden-for-spectators" aria-hidden="true"></i>
{{~!-- squash whitespace --~}}
<h4 class="left-sidebar-title"><span class="views-tooltip-target">{{t 'VIEWS' }}</span></h4>
<ul id="left-sidebar-navigation-list-condensed" class="filters">