From 2e2bcd9619f3ba8b73c250baf5fac182af03a5bf Mon Sep 17 00:00:00 2001 From: Mateusz Mandera Date: Sun, 23 May 2021 17:17:16 +0200 Subject: [PATCH] apple: Rewrite comment in tests in generate_access_url_payload. The original comment is worded rather unclearly, we should explain these details better. --- zerver/tests/test_auth_backends.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/zerver/tests/test_auth_backends.py b/zerver/tests/test_auth_backends.py index 7e816d73bd..b49eea0532 100644 --- a/zerver/tests/test_auth_backends.py +++ b/zerver/tests/test_auth_backends.py @@ -2537,8 +2537,9 @@ class AppleIdAuthBackendTest(AppleAuthMixin, SocialAuthBase): ) def generate_access_url_payload(self, account_data_dict: Dict[str, str]) -> str: - # The ACCESS_TOKEN_URL endpoint works a bit different in standard Oauth2, - # where the token_data_dict contains some essential data. we add that data here. + # The ACCESS_TOKEN_URL endpoint works a bit different than in standard Oauth2, + # and here, similarly to OIDC, id_token is also returned in the response. + # In Apple auth, all the user information is carried in the id_token. return json.dumps( { "access_token": "foobar",