CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-03 21:10:12 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

hotkey: Avoid jQuery sizzle extension :visible.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2025-05-09 17:57:11 -07:00 committed by Tim Abbott
parent b2c1625b0d
commit 26f664be69
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/hotkey.js
View File

@ -550,7 +550,7 @@ export function process_enter_key(e) {
return false;
}
if ($("#preview_message_area").is(":visible")) {
if ($("#compose").hasClass("preview_mode")) {
compose.handle_enter_key_with_preview_open();
return true;
}
@ -600,7 +600,7 @@ export function process_enter_key(e) {
}
export function process_cmd_or_ctrl_enter_key() {
if ($("#preview_message_area").is(":visible")) {
if ($("#compose").hasClass("preview_mode")) {
const cmd_or_ctrl_pressed = true;
compose.handle_enter_key_with_preview_open(cmd_or_ctrl_pressed);
return true;
@ -849,7 +849,7 @@ export function process_hotkey(e, hotkey) {
}
if (compose_state.composing()) {
if ($("#compose .markdown_preview").is(":visible")) {
if ($("#compose").hasClass("preview_mode")) {
compose.show_preview_area();
} else {
compose.clear_preview_area();
@ -1200,7 +1200,7 @@ export function process_hotkey(e, hotkey) {
const $row = message_lists.current.selected_row();
const $emoji_icon = $row.find(".emoji-message-control-button-container");
let emoji_picker_reference;
if ($emoji_icon.is(":visible")) {
if ($emoji_icon.closest(".message_control_button").css("display") !== "none") {
emoji_picker_reference = $emoji_icon[0];
} else {
emoji_picker_reference = $row.find(".message-actions-menu-button")[0];

4
web/tests/hotkey.test.cjs
View File

@ -108,7 +108,9 @@ message_lists.current = {
selected_row() {
const $row = $.create("selected-row-stub");
$row.set_find_results(".message-actions-menu-button", []);
$row.set_find_results(".emoji-message-control-button-container", {is: () => false});
$row.set_find_results(".emoji-message-control-button-container", {
closest: () => ({css: () => "none"}),
});
return $row;
},
selected_message() {