From 262e8c8e8d7457a78cd9fb4e9caf75bb2cd1ea00 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Wed, 19 Apr 2023 12:12:48 -0700 Subject: [PATCH] events: Fix live update when deleting a starred message. Previously, we didn't notify the starred messages code path when processing the event that a message was deleted, resulting in the displayed counter potentially being stale until the app is reloaded. Fixes #25190. --- web/src/message_events.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/web/src/message_events.js b/web/src/message_events.js index 959a977794..2959fd3a00 100644 --- a/web/src/message_events.js +++ b/web/src/message_events.js @@ -24,6 +24,7 @@ import * as pm_list from "./pm_list"; import * as recent_senders from "./recent_senders"; import * as recent_topics_ui from "./recent_topics_ui"; import * as recent_topics_util from "./recent_topics_util"; +import * as starred_messages from "./starred_messages"; import * as stream_list from "./stream_list"; import * as stream_topic_history from "./stream_topic_history"; import * as sub_store from "./sub_store"; @@ -558,4 +559,5 @@ export function remove_messages(message_ids) { } recent_senders.update_topics_of_deleted_message_ids(message_ids); recent_topics_ui.update_topics_of_deleted_message_ids(message_ids); + starred_messages.remove(message_ids); }