From 25999b7056efcefffe91f1e1aefd2605779689fd Mon Sep 17 00:00:00 2001
From: Tim Abbott <tabbott@zulip.com>
Date: Wed, 4 May 2022 11:18:08 -0700
Subject: [PATCH] lint: Ban Help Center relative links without leading /.

Such links would likely end up broken if we change our URL scheme to
no longer be based around URL fragments.
---
 .../templates/settings/organization_permissions_admin.hbs   | 2 +-
 tools/linter_lib/custom_check.py                            | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/static/templates/settings/organization_permissions_admin.hbs b/static/templates/settings/organization_permissions_admin.hbs
index ef0573aa53..845b6ea887 100644
--- a/static/templates/settings/organization_permissions_admin.hbs
+++ b/static/templates/settings/organization_permissions_admin.hbs
@@ -109,7 +109,7 @@
                   is_checked=realm_enable_spectator_access
                   label=admin_settings_label.realm_enable_spectator_access
                   is_disabled=disable_enable_spectator_access_setting
-                  help_link="help/public-access-option"}}
+                  help_link="/help/public-access-option"}}
                 <div class="input-group realm_create_web_public_stream_policy">
                     <label for="realm_create_web_public_stream_policy" class="dropdown-title">{{t "Who can create web-public streams" }}</label>
                     <select name="realm_create_web_public_stream_policy" id="id_realm_create_web_public_stream_policy" class="prop-element" data-setting-widget-type="number">
diff --git a/tools/linter_lib/custom_check.py b/tools/linter_lib/custom_check.py
index 6f10eaa474..0ccac372d1 100644
--- a/tools/linter_lib/custom_check.py
+++ b/tools/linter_lib/custom_check.py
@@ -662,6 +662,12 @@ html_rules: List["Rule"] = [
         "good_lines": ['<img src="{{source_url}}" alt="{{ _(name) }}" />'],
         "bad_lines": ['<img alt="{{ " />'],
     },
+    {
+        "pattern": r"link=\"help/",
+        "description": "Relative links to Help Center should start with /help/",
+        "good_lines": ['link="/help/foo"'],
+        "bad_lines": ['link="help/foo"'],
+    },
     {
         "pattern": r"\bon\w+ ?=",
         "description": "Don't use inline event handlers (onclick=, etc. attributes) in HTML. Instead,"