CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-06 21:18:58 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

hotkey: Call click() on elements with menuitem role in popovers.

Browse Source
This commit is contained in:
Aman Agrawal 2023-10-13 19:54:31 +00:00 committed by Tim Abbott
parent 7932d49956
commit 246c1d7b4e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/hotkey.js
View File

@ -410,11 +410,13 @@ function handle_popover_events(event_name) {
// Returns true if we handled it, false if the browser should.
export function process_enter_key(e) {
if ($(".dropdown.open, .dropup.open").length > 0 && $(e.target).attr("role") === "menuitem") {
// on dropdown menu elements, force a click and prevent default.
// this is because these links do not have an href and so don't force a
// default action.
if (popovers.any_active() && $(e.target).attr("role") === "menuitem") {
// If a popover is open and we pressed Enter on a menu item,
// call click directly on the item to navigate to the `href`.
// trigger("click") doesn't work for them to navigate to `href`.
e.target.click();
e.preventDefault();
popovers.hide_all();
return true;
}