From 2015d55a1709dc0221df542b56cbcdadab0f2f95 Mon Sep 17 00:00:00 2001 From: Riken Shah Date: Tue, 18 May 2021 18:38:27 +0000 Subject: [PATCH] puppeteer_test: Use edit linkifier modal's id to check if it's closed. --- frontend_tests/puppeteer_tests/realm-linkifier.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend_tests/puppeteer_tests/realm-linkifier.ts b/frontend_tests/puppeteer_tests/realm-linkifier.ts index 3d19818ac7..227d0134e3 100644 --- a/frontend_tests/puppeteer_tests/realm-linkifier.ts +++ b/frontend_tests/puppeteer_tests/realm-linkifier.ts @@ -56,7 +56,7 @@ async function test_add_invalid_linkifier_pattern(page: Page): Promise { async function test_edit_linkifier(page: Page): Promise { await page.click(".linkifier_row .edit"); - await page.waitForFunction(() => document.activeElement === $("#linkifier-edit-form-modal")[0]); + await page.waitForFunction(() => document.activeElement?.id === "linkifier-edit-form-modal"); await common.fill_form(page, "form.linkifier-edit-form", { pattern: "(?P[0-9a-f]{40})", url_format_string: "https://trac.example.com/commit/%(num)s", @@ -81,7 +81,7 @@ async function test_edit_linkifier(page: Page): Promise { async function test_edit_invalid_linkifier(page: Page): Promise { await page.click(".linkifier_row .edit"); - await page.waitForFunction(() => document.activeElement === $("#linkifier-edit-form-modal")[0]); + await page.waitForFunction(() => document.activeElement?.id === "linkifier-edit-form-modal"); await common.fill_form(page, "form.linkifier-edit-form", { pattern: "####", url_format_string: "####",