From 1d545efac247663f55a4e9d549a27bb7b36c0846 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Mon, 22 Jun 2020 21:50:30 -0700 Subject: [PATCH] custom_profile_fields: Replace a type: ignore with an assert. Signed-off-by: Anders Kaseorg --- zerver/views/custom_profile_fields.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zerver/views/custom_profile_fields.py b/zerver/views/custom_profile_fields.py index 57ac632deb..a200f548a9 100644 --- a/zerver/views/custom_profile_fields.py +++ b/zerver/views/custom_profile_fields.py @@ -98,8 +98,8 @@ def create_realm_custom_profile_field(request: HttpRequest, validate_custom_profile_field(name, hint, field_type, field_data) try: if is_default_external_field(field_type, field_data): - field_subtype: str = '' - field_subtype = field_data['subtype'] # type: ignore[assignment] # key for "Union[Dict[str, str], str]" can be str + field_subtype = field_data['subtype'] + assert isinstance(field_subtype, str) field = try_add_realm_default_custom_profile_field( realm=user_profile.realm, field_subtype=field_subtype,