From 1ce429ae7cd62fb2383ac47d4416ba1d6608bc06 Mon Sep 17 00:00:00 2001
From: Akarsh Jain <akarsh.jain.790@gmail.com>
Date: Thu, 11 Apr 2024 21:56:24 +0530
Subject: [PATCH] settings: Fix stream permissions warning banner persistence
 issue.

Previously, the stream permissions warning banner failed to hide
after changes to the stream's privacy settings were saved or discarded.
This fix addresses the issue, ensuring the banner behaves as expected
by disappearing when changes to make the stream private are either
saved or discarded.

Fixes: #29625.
---
 web/src/settings_org.js | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/web/src/settings_org.js b/web/src/settings_org.js
index 7bbf205958..e11ce1a0bc 100644
--- a/web/src/settings_org.js
+++ b/web/src/settings_org.js
@@ -517,11 +517,22 @@ export function discard_property_element_changes(elem, for_realm_default_setting
             break;
         case "emojiset":
         case "user_list_style":
-        case "stream_privacy":
             // Because this widget has a radio button structure, it
             // needs custom reset code.
             $elem.find(`input[value='${CSS.escape(property_value)}']`).prop("checked", true);
             break;
+        case "stream_privacy": {
+            $elem.find(`input[value='${CSS.escape(property_value)}']`).prop("checked", true);
+
+            // Hide stream privacy warning banner
+            const $stream_permissions_warning_banner = $(
+                "#stream_permission_settings .stream-permissions-warning-banner",
+            );
+            if (!$stream_permissions_warning_banner.is(":empty")) {
+                $stream_permissions_warning_banner.empty();
+            }
+            break;
+        }
         case "email_notifications_batching_period_seconds":
         case "email_notification_batching_period_edit_minutes":
             settings_notifications.set_notification_batching_ui(