From 1a540241a9fb45deff8a9d09dbb5ad12e86997b6 Mon Sep 17 00:00:00 2001 From: Greg Price Date: Fri, 3 Nov 2017 14:48:42 -0700 Subject: [PATCH] require_server_admin: Cut a redundant bit of request-mutation. The only place this attribute is used is in `update_user_activity`, called only in `process_client`, which won't happen if we end up returning a redirect just below. If we don't, we go and call `add_logging_data` just after, which takes care of this already. --- zerver/decorator.py | 1 - 1 file changed, 1 deletion(-) diff --git a/zerver/decorator.py b/zerver/decorator.py index 01179093c0..202e6f6a51 100644 --- a/zerver/decorator.py +++ b/zerver/decorator.py @@ -417,7 +417,6 @@ def require_server_admin(view_func): @wraps(view_func) def _wrapped_view_func(request, *args, **kwargs): # type: (HttpRequest, *Any, **Any) -> HttpResponse - request._query = view_func.__name__ if not request.user.is_staff: return HttpResponseRedirect(settings.HOME_NOT_LOGGED_IN)