From 178a4b4eff274a5d8aefc0b5debcc4fe8d78aa3a Mon Sep 17 00:00:00 2001 From: PIG208 <359101898@qq.com> Date: Mon, 26 Jul 2021 23:20:16 +0800 Subject: [PATCH] tests: Initialize requests with different post data. Instead of directly changing the `POST` attribute of a request, we utilize the `HostRequestMock` initializer to produce requests with different post data. --- zerver/tests/test_decorators.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/zerver/tests/test_decorators.py b/zerver/tests/test_decorators.py index 16dfe44057..5d8470f5a7 100644 --- a/zerver/tests/test_decorators.py +++ b/zerver/tests/test_decorators.py @@ -135,22 +135,20 @@ class DecoratorTestCase(ZulipTestCase): ) -> HttpResponse: return json_response(data={"number": x + x}) - request = HostRequestMock() - - request.POST = dict(bogus="5555") + request = HostRequestMock(post_data={"bogus": "5555"}) with self.assertRaises(RequestVariableMissingError): double(request) - request.POST = dict(number="3") + request = HostRequestMock(post_data={"number": "3"}) self.assertEqual(orjson.loads(double(request).content).get("number"), 6) - request.POST = dict(x="4") + request = HostRequestMock(post_data={"x": "4"}) self.assertEqual(orjson.loads(double(request).content).get("number"), 8) - request.POST = dict(n="5") + request = HostRequestMock(post_data={"n": "5"}) self.assertEqual(orjson.loads(double(request).content).get("number"), 10) - request.POST = dict(number="6", x="7") + request = HostRequestMock(post_data={"number": "6", "x": "7"}) with self.assertRaises(RequestConfusingParmsError) as cm: double(request) self.assertEqual(str(cm.exception), "Can't decide between 'number' and 'x' arguments")