CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-18 21:04:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

message_notifications: Split title into two parts.

Browse Source 
We separate the prefix and suffix parts of title, so that they
can be translated independently later.
This commit is contained in:
Aman Agrawal 2024-06-24 04:07:01 +00:00 committed by Tim Abbott
parent 98341d811e
commit 07525a2f7d
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
web/src/message_notifications.js
View File

@ -86,11 +86,12 @@ function remove_sender_from_list_of_recipients(message) {
}
function get_notification_title(message, msg_count) {
let title = message.sender_full_name;
let title_prefix = message.sender_full_name;
let title_suffix = "";
let other_recipients;
if (msg_count > 1) {
title = msg_count + " messages from " + title;
title_prefix = msg_count + " messages from " + message.sender_full_name;
}
switch (message.type) {
@ -101,24 +102,24 @@ function get_notification_title(message, msg_count) {
// We use a higher character limit so that the 3rd sender can at least be partially visible so that
// the user can distinguish the group DM.
// If the message has too many recipients to list them all...
if (title.length + other_recipients.length > 50) {
if (title_prefix.length + other_recipients.length > 50) {
// Then count how many people are in the conversation and summarize
other_recipients = message.display_recipient.length - 2 + " more";
}
title += " (to you and " + other_recipients + ")";
title_suffix = " (to you and " + other_recipients + ")";
} else {
title += " (to you)";
title_suffix = " (to you)";
}
break;
case "stream": {
const stream_name = stream_data.get_stream_name_from_id(message.stream_id);
title += " (#" + stream_name + " > " + message.topic + ")";
title_suffix = " (#" + stream_name + " > " + message.topic + ")";
break;
}
}
return title;
return title_prefix + title_suffix;
}
export function process_notification(notification) {