CodeCow/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2026-07-12 21:04:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: Reorder ui state reset calls in narrow.deactivate().

Browse Source 
This is a prep commit towards extracting a reset_ui_state function
which we can call from here, narrow.activate(), recent_topics.show()
and recent_topics.hide().
We want that function because it will enables us to prevent a forced
reflow when navigating from recent_topics to stream: xyz.
This commit is contained in:
YashRE42 2021-11-26 18:46:42 +05:30 committed by Tim Abbott
parent 765514acb8
commit 0624f43633
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
static/js/narrow.js
View File

@ -812,7 +812,6 @@ function handle_post_narrow_deactivate_processes() {
message_view_header.initialize();
narrow_title = "All messages";
notifications.redraw_title();
message_scroll.hide_top_of_narrow_notices();
message_scroll.update_top_of_narrow_notices(message_lists.home);
}
@ -855,15 +854,15 @@ export function deactivate(coming_from_recent_topics = false) {
narrow_state.reset_current_filter();
narrow_banner.hide_empty_narrow_message();
$("body").removeClass("narrowed_view");
$("#zfilt").removeClass("focused_table");
$("#zhome").addClass("focused_table");
message_lists.set_current(message_lists.home);
condense.condense_and_collapse($("#zhome div.message_row"));
narrow_banner.hide_empty_narrow_message();
message_scroll.hide_indicators();
message_scroll.hide_top_of_narrow_notices();
hashchange.save_narrow();
if (message_lists.current.selected_id() !== -1) {