From 025fe9980bb34d746925dbbc488d30fc84377240 Mon Sep 17 00:00:00 2001 From: lonerz Date: Mon, 5 Dec 2016 01:35:14 +0000 Subject: [PATCH] Switch no-empty eslint rule from warning to error (in .eslintrc) --- .eslintrc.json | 2 +- frontend_tests/casper_lib/common.js | 1 + static/js/util.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index 48bcb2b59f..d85854ce1d 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -124,7 +124,7 @@ "no-div-regex": 2, "no-dupe-keys": 2, "no-else-return": 2, - "no-empty": 1, + "no-empty": 2, "no-empty-character-class": 2, "no-eq-null": 2, "no-eval": 2, diff --git a/frontend_tests/casper_lib/common.js b/frontend_tests/casper_lib/common.js index 23a19bdbbb..8b6e4fe142 100644 --- a/frontend_tests/casper_lib/common.js +++ b/frontend_tests/casper_lib/common.js @@ -337,4 +337,5 @@ return exports; try { exports.common = common; } catch (e) { + // continue regardless of error } diff --git a/static/js/util.js b/static/js/util.js index b709afbc03..6d6da9fa3a 100644 --- a/static/js/util.js +++ b/static/js/util.js @@ -161,6 +161,7 @@ exports.strcmp = (function () { var collator = new Intl.Collator(); return collator.compare; } catch (e) { + // continue regardless of error } return function util_strcmp (a, b) {