mirror of
https://github.com/tailscale/tailscale.git
synced 2026-07-20 21:23:07 +08:00
477d5a43df
Currently, PeerAPI DNS is only allowed if
1. The peer is owned by the same user as this device, or
2. The node is an exit node or app connector
a. and the peer has access to a hypothetical DNS server at 0.0.0.0:53
(which approximately means "the peer has access to
autogroup:internet")
None of this is useful for conn25. This adds the most basic of hooks
(and converts the existing logic to a hook, which should improve clarity
and lead to the possibility of moving the existing checks into feature
packages in future).
There is an extra filter based on the name being queried that is
performed later. It refuses names in
tailcfg.DNSConfig.ExitNodeFilteredSet. That filter is not modified by
this change.
With this change, if conn25 is configured as a connector, then all
PeerAPI DNS queries are permitted (still subject to the
ExitNodeFilteredSet as noted above).
More work is required: the goal before release (i.e. the WIPCode check
is removed) is that each query should be checked against the list of
domains in the requested conn25 app. For now, this only verifies that
conn25 is configured (and does not include the autogroup:internet
check, which is not how conn25 grants will operate when implemented,
soon).
This change has been manually tested against the scenario outlined in
tailscale/corp#40117; unfortunately the code's structure makes writing a
unit test difficult. The more comprehensive changes needed for
tailscale/corp#40076 should include an integration test that covers this
case.
The hook must go in the ipnlocal package rather than the usual extension
host to prevent a circular dependency on the ipnlocal.PeerAPIHandler
interface. Registering PeerAPI handlers uses a similar strategy, likely
because of, at least in part, this same problem.
Updates tailscale/corp#40076
Fixes tailscale/corp#40117
Change-Id: I367714170b509d7a421f62672e5824b3590c2b9c
Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>
|
||
|---|---|---|
| .. | ||
| ace | ||
| acme | ||
| appconnectors | ||
| awsparamstore | ||
| buildfeatures | ||
| c2n | ||
| capture | ||
| clientupdate | ||
| condlite/expvar | ||
| condregister | ||
| conn25 | ||
| debugportmapper | ||
| doctor | ||
| drive | ||
| featuretags | ||
| identityfederation | ||
| linkspeed | ||
| linuxdnsfight | ||
| oauthkey | ||
| portlist | ||
| portmapper | ||
| posture | ||
| relayserver | ||
| routecheck | ||
| runtimemetrics | ||
| sdnotify | ||
| ssh | ||
| syspolicy | ||
| taildrop | ||
| tailnetlock | ||
| tap | ||
| tpm | ||
| tundevstats | ||
| useproxy | ||
| wakeonlan | ||
| feature.go | ||
| hooks.go | ||
| sdnotify.go | ||