tailscale/wgengine
Jonathan Nobels 3e89068792
net/netmon, wgengine/userspace: purge ChangeDelta.Major and address TODOs (#17823)
updates tailscale/corp#33891

Addresses several older the TODO's in netmon.  This removes the 
Major flag precomputes the ChangeDelta state, rather than making
consumers of ChangeDeltas sort that out themselves.   We're also seeing
a lot of ChangeDelta's being flagged as "Major" when they are
not interesting, triggering rebinds in wgengine that are not needed.  This
cleans that up and adds a host of additional tests.

The dependencies are cleaned, notably removing dependency on netmon
itself for calculating what is interesting, and what is not.  This includes letting
individual platforms set a bespoke global "IsInterestingInterface"
function.  This is only used on Darwin.

RebindRequired now roughly follows how "Major" was historically
calculated but includes some additional checks for various
uninteresting events such as changes in interface addresses that
shouldn't trigger a rebind.  This significantly reduces thrashing (by
roughly half on Darwin clients which switching between nics).   The individual
values that we roll  into RebindRequired are also exposed so that
components consuming netmap.ChangeDelta can ask more
targeted questions.

Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
2025-12-17 12:32:40 -05:00
..
bench types/netmap: remove PrivateKey from NetworkMap 2025-11-16 15:32:51 -08:00
filter wgengine/filter: add check for unknown proto 2025-01-24 12:20:44 +01:00
magicsock net/{packet,tstun},wgengine: update disco key when receiving via TSMP (#18158) 2025-12-10 14:27:20 -05:00
netlog wgengine/netlog: strip dot suffix from node name (#17954) 2025-11-17 19:17:02 -08:00
netstack all: rename variables with lowercase-l/uppercase-I 2025-11-18 09:12:34 +00:00
router all: rename variables with lowercase-l/uppercase-I 2025-11-18 09:12:34 +00:00
wgcfg types/netmap: remove PrivateKey from NetworkMap 2025-11-16 15:32:51 -08:00
wgint wgengine{,/wgint}: add wgint.Peer wrapper type, add to wgengine.Engine 2024-02-28 09:50:18 -08:00
wglog all: use Go 1.22 range-over-int 2024-04-16 15:32:38 -07:00
winnet all: add test for package comments, fix, add comments as needed 2024-07-10 09:57:00 -07:00
mem_ios.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
pendopen_omit.go wgengine: stop importing flowtrack when unused 2025-10-04 20:52:13 -07:00
pendopen.go wgengine: stop importing flowtrack when unused 2025-10-04 20:52:13 -07:00
userspace_ext_test.go health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085) 2025-09-16 11:25:29 -04:00
userspace_test.go net/tstun: add TSMPDiscoAdvertisement to TSMPPing (#17995) 2025-11-25 15:35:38 -05:00
userspace.go net/netmon, wgengine/userspace: purge ChangeDelta.Major and address TODOs (#17823) 2025-12-17 12:32:40 -05:00
watchdog_omit.go ipn/ipnlocal, engine: avoid runtime/pprof with two usages of ts_omit_debug 2025-09-30 14:58:25 -07:00
watchdog_test.go health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085) 2025-09-16 11:25:29 -04:00
watchdog.go ipn/ipnlocal: remove all the weird locking (LockedOnEntry, UnlockEarly, etc) 2025-11-13 19:20:07 -08:00
wgengine.go ipn/ipnlocal: remove all the weird locking (LockedOnEntry, UnlockEarly, etc) 2025-11-13 19:20:07 -08:00