tailscale/util/linuxfw
Brad Fitzpatrick 5ef3713c9f cmd/vet: add subtestnames analyzer; fix all existing violations
Add a new vet analyzer that checks t.Run subtest names don't contain
characters requiring quoting when re-running via "go test -run". This
enforces the style guide rule: don't use spaces or punctuation in
subtest names.

The analyzer flags:
- Direct t.Run calls with string literal names containing spaces,
  regex metacharacters, quotes, or other problematic characters
- Table-driven t.Run(tt.name, ...) calls where tt ranges over a
  slice/map literal with bad name field values

Also fix all 978 existing violations across 81 test files, replacing
spaces with hyphens and shortening long sentence-like names to concise
hyphenated forms.

Updates #19242

Change-Id: Ib0ad96a111bd8e764582d1d4902fe2599454ab65
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2026-04-05 15:52:51 -07:00
..
linuxfwtest all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
detector.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
fake_netfilter.go util/linuxfw,wgengine/router: add connmark rules for rp_filter workaround (#18860) 2026-03-04 14:09:11 -05:00
fake.go util/linuxfw: fix nil pointer panic in connmark rules without IPv6 (#18946) 2026-03-10 15:19:15 -04:00
helpers.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
iptables_disabled.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
iptables_for_svcs_test.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
iptables_for_svcs.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
iptables_runner_test.go util/linuxfw: fix nil pointer panic in connmark rules without IPv6 (#18946) 2026-03-10 15:19:15 -04:00
iptables_runner.go util/linuxfw: fix nil pointer panic in connmark rules without IPv6 (#18946) 2026-03-10 15:19:15 -04:00
iptables.go all: use Go 1.26 things, run most gofix modernizers 2026-03-06 13:32:03 -08:00
linuxfw.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
nftables_for_svcs_test.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
nftables_for_svcs.go all: use Go 1.26 things, run most gofix modernizers 2026-03-06 13:32:03 -08:00
nftables_runner_test.go cmd/vet: add subtestnames analyzer; fix all existing violations 2026-04-05 15:52:51 -07:00
nftables_runner.go types/ptr: deprecate ptr.To, use Go 1.26 new 2026-03-05 20:13:18 -08:00
nftables_types.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00
nftables.go all: remove AUTHORS file and references to it 2026-01-23 15:49:45 -08:00