12 Commits

Author	SHA1	Message	Date
Brad Fitzpatrick	82cfea90ca	all: fix JSON serialization under Go 1.27's finalized encoding/json/v2 ... Go 1.27 enables GOEXPERIMENT=jsonv2 by default: encoding/json is now backed by the json/v2 machinery, and github.com/go-json-experiment/json compiles as a thin alias of the standard library's encoding/json/v2. Several tag options and behaviors we relied on did not make the cut for the final Go 1.27 API, breaking tailscaled at runtime and four packages' tests. This change adapts to the final API while keeping the wire format byte-for-byte identical on all Go versions. First, the `format` tag option was demoted to experimental. Its mere presence in a struct tag now makes marshaling and unmarshaling fail at runtime. tailcfg.SSHAction.SessionDuration had `format:nano` (added in a2dc517d7 to pin the v1 representation), so on Go 1.27 any netmap containing an SSH policy failed to decode, breaking every PollNetMap. Remove the option here and in net/speedtest; time.Duration still marshals as int64 nanoseconds under encoding/json on all Go versions (Go 1.27's v1 mode sets FormatDurationAsNano by default), so old clients and servers are unaffected. Add a regression test locking in the exact wire format. Consequently, invert the cmd/vet jsontags rule: it previously required an explicit `format` tag on time.Duration fields, which is now exactly wrong. It now rejects any `format` tag option, which would have caught this bug in CI. Second, the `inline` tag option was renamed to `embed`. The standard library silently ignores `inline`, while the pinned go-json-experiment module (used on Go 1.26) only knows `inline`. Specify both options in types/prefs and logtail; each implementation ignores the option it does not know, producing identical output. Drop `inline` once we require Go 1.27. Third, encoding/json (v1) now dispatches to MarshalJSONTo and UnmarshalJSONFrom methods and its v1 options flow into nested jsonv2.MarshalEncode calls. Types whose v1 methods deliberately routed through jsonv2 for v2 semantics (types/opt.Value, the types/prefs preference types) would silently change wire format (e.g. nil slices becoming null). Pin jsonv2.DefaultOptionsV2 in their jsonv2 methods so the representation is the same regardless of the entry point. Finally, json.Marshal costs one more allocation under Go 1.27, tripping the types/logger.AsJSON alloc test. Switch its fmt.Formatter to jsonv2.MarshalWrite with explicit v1 options, which writes directly to the fmt.State: one allocation on both toolchains with unchanged output. Depaware files pick up the go-json-experiment/json/v1 options shim as a new dependency of types/logger. With this change, go test ./... passes with both Go 1.26.5 and go1.27rc2. Updates #20220 Fixes #20528 Fixes #20254 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: I694c7d57fd81e55a579c579e9be10032bca569d4	2026-07-19 09:58:50 -07:00
Alex Chan	8379d5955f	ipn: remove the last traces of Prefs.AllowSingleHosts ... We stopped reading this field nearly two years ago, with a TODO comment to remove it sometime in 2025. It is now 2026. Updates #12058 Change-Id: I8ddf1c2e4c3c428e8d45a6491d3899368ec52c30 Signed-off-by: Alex Chan <alexc@tailscale.com>	2026-06-26 15:31:38 +01:00
Brad Fitzpatrick	2a64c03c95	types/ptr: deprecate ptr.To, use Go 1.26 new ... Updates #18682 Change-Id: I62f6aa0de2a15ef8c1435032c6aa74a181c25f8f Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2026-03-05 20:13:18 -08:00
Will Norris	3ec5be3f51	all: remove AUTHORS file and references to it ... This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <will@tailscale.com>	2026-01-23 15:49:45 -08:00
Alex Chan	c2e474e729	all: rename variables with lowercase-l/uppercase-I ... See http://go/no-ell Signed-off-by: Alex Chan <alexc@tailscale.com> Updates #cleanup Change-Id: I8c976b51ce7a60f06315048b1920516129cc1d5d	2025-11-18 09:12:34 +00:00
Maisem Ali	882b05fff9	cmd/viewer: add field comments to generated view methods ... Extract field comments from AST and include them in generated view methods. Comments are preserved from the original struct fields to provide documentation for the view accessors. Fixes #16958 Signed-off-by: Maisem Ali <3953239+maisem@users.noreply.github.com>	2025-08-27 09:58:59 -07:00
Joe Tsai	fbb91758ac	cmd/viewer, types/views: implement support for json/v2 (#16852) ... This adds support for having every viewer type implement jsonv2.MarshalerTo and jsonv2.UnmarshalerFrom. This provides a significant boost in performance as the json package no longer needs to validate the entirety of the JSON value outputted by MarshalJSON, nor does it need to identify the boundaries of a JSON value in order to call UnmarshalJSON. For deeply nested and recursive MarshalJSON or UnmarshalJSON calls, this can improve runtime from O(N²) to O(N). This still references "github.com/go-json-experiment/json" instead of the experimental "encoding/json/v2" package now available in Go 1.25 under goexperiment.jsonv2 so that code still builds without the experiment tag. Of note, the "github.com/go-json-experiment/json" package aliases the standard library under the right build conditions. Updates tailscale/corp#791 Signed-off-by: Joe Tsai <joetsai@digital-static.net>	2025-08-14 13:46:48 -07:00
Joe Tsai	3d28aa19cb	all: statically enforce json/v2 interface satisfaction (#15154) ... The json/v2 prototype is still in flux and the API can/will change. Statically enforce that types implementing the v2 methods satisfy the correct interface so that changes to the signature can be statically detected by the compiler. Updates tailscale/corp#791 Signed-off-by: Joe Tsai <joetsai@digital-static.net>	2025-02-27 12:33:31 -08:00
Joe Tsai	ae303d41dd	go.mod: bump github.com/go-json-experiment/json (#15010) ... The upstream module has seen significant work making the v1 emulation layer a high fidelity re-implementation of v1 "encoding/json". This addresses several upstream breaking changes: * MarshalJSONV2 renamed as MarshalJSONTo * UnmarshalJSONV2 renamed as UnmarshalJSONFrom * Options argument removed from MarshalJSONV2 * Options argument removed from UnmarshalJSONV2 Updates tailscale/corp#791 Signed-off-by: Joe Tsai <joetsai@digital-static.net>	2025-02-27 11:35:54 -08:00
Brad Fitzpatrick	cfda1ff709	cmd/viewer,all: consistently use "read-only" instead of "readonly" ... Updates #cleanup Change-Id: I8e4e3497d3d0ec5b16a73aedda500fe5cfa37a67 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2025-01-14 08:26:56 -08:00
Nick Khyl	da9965d51c	cmd/viewer,types/views,various: avoid allocations in pointer field getters whenever possible ... In this PR, we add a generic views.ValuePointer type that can be used as a view for pointers to basic types and struct types that do not require deep cloning and do not have corresponding view types. Its Get/GetOk methods return stack-allocated shallow copies of the underlying value. We then update the cmd/viewer codegen to produce getters that return either concrete views when available or ValuePointer views when not, for pointer fields in generated view types. This allows us to avoid unnecessary allocations compared to returning pointers to newly allocated shallow copies. Updates #14570 Signed-off-by: Nick Khyl <nickk@tailscale.com>	2025-01-14 09:37:10 -06:00
Nick Khyl	af3d3c433b	types/prefs: add a package containing generic preference types ... This adds a new package containing generic types to be used for defining preference hierarchies. These include prefs.Item, prefs.List, prefs.StructList, and prefs.StructMap. Each of these types represents a configurable preference, holding the preference's state, value, and metadata. The metadata includes the default value (if it differs from the zero value of the Go type) and flags indicating whether a preference is managed via syspolicy or is hidden/read-only for another reason. This information can be marshaled and sent to the GUI, CLI and web clients as a source of truth regarding preference configuration, management, and visibility/mutability states. We plan to use these types to define device preferences, such as the updater preferences, the permission mode to be used on Windows with #tailscale/corp#18342, and certain global options that are currently exposed as tailscaled flags. We also aim to eventually use these types for profile-local preferences in ipn.Prefs and and as a replacement for ipn.MaskedPrefs. The generic preference types are compatible with the tailscale.com/cmd/viewer and tailscale.com/cmd/cloner utilities. Updates #12736 Signed-off-by: Nick Khyl <nickk@tailscale.com>	2024-08-21 12:44:38 -05:00