CodeCow/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-07-20 21:23:07 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity
474 Commits 1,197 Branches 234 Tags
crawshaw/hostinfo
Commit Graph
48 Commits
Author SHA1 Message Date
David Crawshaw 58c65eeff4 controlclient: do not send duplicate hostinfo/netinfo 
This should never happen, so log when it does so we can fix it.

Signed-off-by: David Crawshaw <[email protected]>
 2020-04-02 11:19:05 +11:00
Brad Fitzpatrick 4524dcf51e version: move runtime.OS to tailscale OS mapping func to version 
So other code can use this without duplicating the policy.
 2020-04-01 08:50:56 -07:00
David Crawshaw 0590ad68be controlclient, ipn: adjust tests for authURL semantic changes 
The tests cheat at filling out web forms by directly POSTing to
the target. The target for authURLs has changed slightly, the base
authURL now redirects the user to the login page.

Additionally, the authURL cycle now checks the cookie is set
correctly, so we add cookie jars where necessary to pass the
cookie through.
 2020-03-30 15:51:46 +11:00
Brad FitzpatrickandBrad Fitzpatrick 8b3f6be008 control/controlclient: flip IPv6 to be on by default 
The DEBUG_INCLUDE_IPV6 environment variable is now an opt-out.

Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-03-26 22:02:56 -07:00
Avery Pennarun a56e853b72 cmd/relaynode: delete it! 
tailscale+tailscaled now completely obsoletes relaynode, so let's let
it finally go away.
 2020-03-25 04:48:15 -04:00
David Anderson 73fccd8b06 control/controlclient: remove old compat PacketFilter initialization. 
Signed-off-by: David Anderson <[email protected]>
 2020-03-24 16:00:41 -07:00
Brad FitzpatrickandBrad Fitzpatrick 64aff0db7b control/controlclient: add TODO to delete the UAPI method 2020-03-24 07:25:14 -07:00
Brad Fitzpatrick af277a6762 controlclient, magicsock: add debug knob to request IPv6 endpoints 
Add opt-in method to request IPv6 endpoints from the control plane.
For now they should just be skipped. A previous version of this CL was
unconditional and reportedly had problems that I can't reproduce. So
make it a knob until the mystery is solved.

Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-03-20 14:27:24 -07:00
David Crawshaw 13eed1e88b controlclient: remove common log on very quiet nodes 
Signed-off-by: David Crawshaw <[email protected]>
 2020-03-21 07:11:10 +11:00
David Anderson 0be475ba46 Revert "tailcfg, controlclient, magicsock: request IPv6 endpoints, but ignore them" 
Breaks something deep in wireguard or magicsock's brainstem, no packets at all
can flow. All received packets fail decryption with "invalid mac1".

This reverts commit 94024355ed.

Signed-off-by: David Anderson <[email protected]>
 2020-03-20 03:26:17 -07:00
Brad FitzpatrickandBrad Fitzpatrick 94024355ed tailcfg, controlclient, magicsock: request IPv6 endpoints, but ignore them 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-03-19 21:01:52 -07:00
Brad Fitzpatrick 073bb8de80 control/controlclient: don't use Node as value type 2020-03-19 13:19:02 -07:00
David Crawshaw 73cae4eb11 tailcfg, controlclient: standardize on wgcfg ShortString key printing 
Signed-off-by: David Crawshaw <[email protected]>
 2020-03-19 09:17:34 +11:00
David Crawshaw 5a0822eefd controlclient, ipn: fix tests for new control param 2020-03-18 08:35:34 +11:00
Brad Fitzpatrick e085aec8ef all: update to wireguard-go API changes 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-03-17 08:53:05 -07:00
David Crawshaw 1b2be3f1c8 controlclient: test peer keepalive directive 
Signed-off-by: David Crawshaw <[email protected]>
 2020-03-14 14:11:07 -05:00
David Crawshaw 8712164a0a controlclient: use per-peer KeepAlive signal 
Signed-off-by: David Crawshaw <[email protected]>
 2020-03-14 14:11:03 -05:00
Brad Fitzpatrick 19cc4f8b8e control/controlclient: remove a number literal in string slice offset 2020-03-13 09:48:15 -07:00
Avery Pennarun 8b8e3f08a0 Fix staticcheck complaint. 2020-03-12 23:33:51 -04:00
Avery Pennarun b4897e7de8 controlclient/netmap: write our own b.ConciseDiffFrom(a) function. 
This removes the need for go-cmp, which is extremely bloaty so we had
to leave it out of iOS. As a result, we had also left it out of macOS,
and so we didn't print netmap diffs at all on darwin-based platforms.
Oops.

As a bonus, the output format of the new function is way better.

Minor oddity: because I used the dumbest possible diff algorithm, the
sort order is a bit dumb. We print all "removed" lines and then print
all "added" lines, rather than doing the usual diff-like thing of
interspersing them. This probably doesn't matter (maybe it's an
improvement).
 2020-03-12 23:01:08 -04:00
Avery Pennarun 96bb05ce2f controlclient: reformat netmap.Concise() and add DERP server info. 
The .Concise() view had grown hard to read over time. Originally, we
assumed a peer almost always had just one endpoint and one-or-more
allowedips. With magicsock, we now almost always have multiple
endpoints per peer. And empirically, almost every peer has only one
allowedip.

Change their order so we can line up allowedips vertically. Also do
some tweaking to make multiple endpoints easier to read.

While we're here, add a column to show the home DERP server of each
peer, if any.
 2020-03-12 22:29:24 -04:00
Avery Pennarun f2e2ffa423 controlclient: log the entire netmap up to every 5 minutes. 
We log it once upon receiving the first copy of the map, then
subsequently when a new one appears, but only if we haven't logged one
less than 5 minutes ago.

This avoids overly cluttering the log (as we did before, logging the
netmap every time one appeared, which could be hundreds of lines every
few seconds), but still gives the log enough context to help in
diagnosing problems retroactively.
 2020-03-12 22:28:11 -04:00
David Crawshaw d99498bee2 controlclient: set default TimeNow function 
Panic on call to nil func found by expanded ipn/e2e_test.

Signed-off-by: David Crawshaw <[email protected]>
 2020-03-08 09:03:27 -04:00
Brad FitzpatrickandBrad Fitzpatrick b27d4c017a magicsock, wgengine, ipn, controlclient: plumb regular netchecks to map poll 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-03-04 08:19:45 -08:00
David CrawshawandDavid Crawshaw 61529ac459 controlclient, tailcfg: deliver DERP addresses in a separate field 
We still include them directly in the controlclient network map
just where we have been. Client plumbing we can do later.

Signed-off-by: David Crawshaw <[email protected]>
 2020-03-02 17:16:17 -05:00
Brad Fitzpatrick 7172f3dbf4 version: add IsMobile func 
And use it control/controlclient.
 2020-03-02 12:37:28 -08:00
David Crawshaw d417be6a4b controlclinet: clone filter.MatchAllowAll 
This avoids a non-obvious data race, where the JSON decoder ends
up creating do-nothing writes into global variables.

	==================
	WARNING: DATA RACE
	Write at 0x0000011e1860 by goroutine 201:
	  tailscale.com/wgengine/packet.(*IP).UnmarshalJSON()
	      /home/crawshaw/repo/corp/oss/wgengine/packet/packet.go:83 +0x2d9
	  encoding/json.(*decodeState).literalStore()
	      /home/crawshaw/go/go/src/encoding/json/decode.go:877 +0x445e
	...
	  encoding/json.Unmarshal()
	      /home/crawshaw/go/go/src/encoding/json/decode.go:107 +0x1de
	  tailscale.com/control/controlclient.(*Direct).decodeMsg()
	      /home/crawshaw/repo/corp/oss/control/controlclient/direct.go:615 +0x1ab
	  tailscale.com/control/controlclient.(*Direct).PollNetMap()
	      /home/crawshaw/repo/corp/oss/control/controlclient/direct.go:525 +0x1053
	  tailscale.com/control/controlclient.(*Client).mapRoutine()
	      /home/crawshaw/repo/corp/oss/control/controlclient/auto.go:428 +0x3a6
	Previous read at 0x0000011e1860 by goroutine 86:
	  tailscale.com/wgengine/filter.matchIPWithoutPorts()
	      /home/crawshaw/repo/corp/oss/wgengine/filter/match.go:108 +0x91
	  tailscale.com/wgengine/filter.(*Filter).runIn()
	      /home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:147 +0x3c6
	  tailscale.com/wgengine/filter.(*Filter).RunIn()
	      /home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:127 +0xb0
	  tailscale.com/wgengine.(*userspaceEngine).SetFilter.func1()
	      /home/crawshaw/repo/corp/oss/wgengine/userspace.go:390 +0xfc
	  github.com/tailscale/wireguard-go/device.(*Device).RoutineDecryption()
	      /home/crawshaw/repo/corp/wireguard-go/device/receive.go:295 +0xa1f

For #112

Signed-off-by: David Crawshaw <[email protected]>
 2020-02-28 22:33:06 -05:00
David Crawshaw 4e3ff4b63b controlclient: allow prefixed endpoints in tests 2020-02-27 16:52:14 -05:00
Brad Fitzpatrick 25797c8c2a all: rename deep "Copy" methods to conventional Go name "Clone" 2020-02-27 12:20:29 -08:00
David Crawshaw 6879581891 controlclient: adjust user expiry test 
Signed-off-by: David Crawshaw <[email protected]>
 2020-02-26 09:44:42 -05:00
Brad Fitzpatrick 758744a4e3 Fix some Hostinfo value usages from the previous commit. 2020-02-25 11:01:20 -08:00
Brad Fitzpatrick d8de11a01b control: make Hostinfo accessed by pointer 
Fix potential races in copying aliased slices by value.

Also few little doc updates.

Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-02-25 10:35:51 -08:00
Brad Fitzpatrick cc7b9b0dff control/controlclient: fix priority of DERP server, add comment 2020-02-21 14:47:05 -08:00
Brad Fitzpatrick c02f4b5a1f control/controlclient: add temporary mechanism to force derp on 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-02-21 14:09:24 -08:00
Avery Pennarun 57bbafde84 cmd/relaynode: drop local --acl-file in favour of central packet filter. 
relaynode itself is not long for this world, deprecated in favour of
tailscale/tailscaled. But now that the control server supports central
distribution of packet filters, let's actually take advantage of it in
a final, backward compatible release of relaynode.
 2020-02-20 00:15:43 -05:00
David Anderson 59ba2e6316 ipn: implement Prefs.Equals efficiently. 
Signed-off-by: David Anderson <[email protected]>
 2020-02-17 15:01:23 -08:00
Brad FitzpatrickandBrad Fitzpatrick 2896be60db Move "logger" package to under types, now that we have it. 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-02-14 20:23:05 -08:00
Brad FitzpatrickandBrad Fitzpatrick 747c7d7ce2 types/empty: add Message, stop using mysterious *struct{} 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-02-14 13:35:49 -08:00
Brad FitzpatrickandBrad Fitzpatrick 587c3fcac4 control/controlclient, wgengine/magicsock: misc cleanups 
Signed-off-by: Brad Fitzpatrick <[email protected]>
 2020-02-14 09:50:08 -08:00
David Crawshaw 2b947b3b40 controlclient: handle nil Logf option 2020-02-11 15:08:07 -05:00
Shawn SmithandDave Anderson 1ca83fd205 fix typos 
Signed-off-by: Shawn Smith <[email protected]>
 2020-02-11 08:55:11 -08:00
David CrawshawandDavid Crawshaw 33dfb8999e controlclient, ipn: update tests for key pointer change 
Signed-off-by: David Crawshaw <[email protected]>
 2020-02-11 04:55:07 -05:00
David Anderson 1cd278aa0b control/policy: make error strings staticcheck-compliant. 
Signed-off-by: David Anderson <[email protected]>
 2020-02-10 23:23:57 -08:00
David Anderson 542f46ed4d controlclient: remove unused function. 
Signed-off-by: David Anderson <[email protected]>
 2020-02-10 23:21:08 -08:00
David Anderson 2227ede8af controlclient: fix staticcheck lint. 
Signed-off-by: David Anderson <[email protected]>
 2020-02-10 23:16:13 -08:00
David Anderson fe9af19da9 controlclient: remove unnecessary comparison to bool. 
Signed-off-by: David Anderson <[email protected]>
 2020-02-10 23:14:38 -08:00
David Crawshaw 87334fb332 wgengine, controlclient: fewer pointers in wgcfg key types 
Signed-off-by: David Crawshaw <[email protected]>
 2020-02-10 22:09:59 -05:00
Earl Lee a8d8b8719a Move Linux client & common packages into a public repo. 2020-02-09 09:32:57 -08:00