32 Commits

Include renames

Author	SHA1	Message	Date
James TuckerandJames Tucker	25b8ed8d9e	control/controlknobs,net/{batching,tstun},wgengine: add nodecaps to disable UDP & TUN GRO/GSO ... Add four control-plane node attributes that let us disable UDP GSO/GRO on the magicsock UDP socket and UDP/TCP GRO on the Tailscale TUN device. These complement the pre-existing TS_DEBUG_DISABLE_UDP_{GRO,GSO} and TS_TUN_DISABLE_{UDP,TCP}_GRO envknobs. They exist so we can mitigate upstream Linux kernel regressions on a deployed fleet without requiring a client release, after two incidents (#13041, #19777) where buggy kernel patches landed upstream and the fix took an excessively long time to reach downstream distros. Knob changes are reacted to in setNetworkMapInternal / SetNetworkMap via a comparison against a cached "last applied" value and only an actual transition triggers work: magicsock Rebind()+ReSTUN for UDP, ApplyGROKnobs for TUN. The TUN side is gated by buildfeatures.HasGRO and is one-way (wireguard-go GRO disablement is sticky); re-enabling requires a client restart. Updates #13041 Updates #19777 Change-Id: I802993070afa659cc06809bb0bfbb7f8a0cdb273 Signed-off-by: James Tucker <[email protected]>	2026-05-27 17:10:14 -07:00
Brad FitzpatrickandBrad Fitzpatrick	5ef3713c9f	cmd/vet: add subtestnames analyzer; fix all existing violations ... Add a new vet analyzer that checks t.Run subtest names don't contain characters requiring quoting when re-running via "go test -run". This enforces the style guide rule: don't use spaces or punctuation in subtest names. The analyzer flags: - Direct t.Run calls with string literal names containing spaces, regex metacharacters, quotes, or other problematic characters - Table-driven t.Run(tt.name, ...) calls where tt ranges over a slice/map literal with bad name field values Also fix all 978 existing violations across 81 test files, replacing spaces with hyphens and shortening long sentence-like names to concise hyphenated forms. Updates #19242 Change-Id: Ib0ad96a111bd8e764582d1d4902fe2599454ab65 Signed-off-by: Brad Fitzpatrick <[email protected]>	2026-04-05 15:52:51 -07:00
Brad FitzpatrickandBrad Fitzpatrick	2a64c03c95	types/ptr: deprecate ptr.To, use Go 1.26 new ... Updates #18682 Change-Id: I62f6aa0de2a15ef8c1435032c6aa74a181c25f8f Signed-off-by: Brad Fitzpatrick <[email protected]>	2026-03-05 20:13:18 -08:00
Will NorrisandWill Norris	3ec5be3f51	all: remove AUTHORS file and references to it ... This file was never truly necessary and has never actually been used in the history of Tailscale's open source releases. A Brief History of AUTHORS files --- The AUTHORS file was a pattern developed at Google, originally for Chromium, then adopted by Go and a bunch of other projects. The problem was that Chromium originally had a copyright line only recognizing Google as the copyright holder. Because Google (and most open source projects) do not require copyright assignemnt for contributions, each contributor maintains their copyright. Some large corporate contributors then tried to add their own name to the copyright line in the LICENSE file or in file headers. This quickly becomes unwieldy, and puts a tremendous burden on anyone building on top of Chromium, since the license requires that they keep all copyright lines intact. The compromise was to create an AUTHORS file that would list all of the copyright holders. The LICENSE file and source file headers would then include that list by reference, listing the copyright holder as "The Chromium Authors". This also become cumbersome to simply keep the file up to date with a high rate of new contributors. Plus it's not always obvious who the copyright holder is. Sometimes it is the individual making the contribution, but many times it may be their employer. There is no way for the proejct maintainer to know. Eventually, Google changed their policy to no longer recommend trying to keep the AUTHORS file up to date proactively, and instead to only add to it when requested: https://opensource.google/docs/releasing/authors. They are also clear that: > Adding contributors to the AUTHORS file is entirely within the > project's discretion and has no implications for copyright ownership. It was primarily added to appease a small number of large contributors that insisted that they be recognized as copyright holders (which was entirely their right to do). But it's not truly necessary, and not even the most accurate way of identifying contributors and/or copyright holders. In practice, we've never added anyone to our AUTHORS file. It only lists Tailscale, so it's not really serving any purpose. It also causes confusion because Tailscalars put the "Tailscale Inc & AUTHORS" header in other open source repos which don't actually have an AUTHORS file, so it's ambiguous what that means. Instead, we just acknowledge that the contributors to Tailscale (whoever they are) are copyright holders for their individual contributions. We also have the benefit of using the DCO (developercertificate.org) which provides some additional certification of their right to make the contribution. The source file changes were purely mechanical with: git ls-files | xargs sed -i -e 's/\(Tailscale Inc &\) AUTHORS/\1 contributors/g' Updates #cleanup Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <[email protected]>	2026-01-23 15:49:45 -08:00
Alex ValiushkoandGitHub	c40f352103	net/udprelay: expose peer relay metrics (#18218) ... Adding both user and client metrics for peer relay forwarded bytes and packets, and the total endpoints gauge. User metrics: tailscaled_peer_relay_forwarded_packets_total{transport_in, transport_out} tailscaled_peer_relay_forwarded_bytes_total{transport_in, transport_out} tailscaled_peer_relay_endpoints_total{} Where the transport labels can be of "udp4" or "udp6". Client metrics: udprelay_forwarded_(packets|bytes)_udp(4|6)_udp(4|6) udprelay_endpoints RELNOTE: Expose tailscaled metrics for peer relay. Updates tailscale/corp#30820 Change-Id: I1a905d15bdc5ee84e28017e0b93210e2d9660259 Signed-off-by: Alex Valiushko <[email protected]>	2025-12-18 16:12:50 -08:00
Jordan WhitedandJordan Whited	824027305a	cmd/tailscale/cli,ipn,all: make peer relay server port a *uint16 ... In preparation for exposing its configuration via ipn.ConfigVAlpha, change {Masked}Prefs.RelayServerPort from *int to *uint16. This takes a defensive stance against invalid inputs at JSON decode time. 'tailscale set --relay-server-port' is currently the only input to this pref, and has always sanitized input to fit within a uint16. Updates tailscale/corp#34591 Signed-off-by: Jordan Whited <[email protected]>	2025-11-25 19:40:17 -08:00
Jordan WhitedandJordan Whited	7426eca163	cmd/tailscale,feature/relayserver,ipn: add relay-server-static-endpoints set flag ... Updates tailscale/corp#31489 Updates #17791 Signed-off-by: Jordan Whited <[email protected]>	2025-11-24 16:37:15 -08:00
Jordan WhitedandJordan Whited	9245c7131b	feature/relayserver: don't publish from within a subscribe fn goroutine ... Updates #17830 Signed-off-by: Jordan Whited <[email protected]>	2025-11-21 12:28:38 -08:00
Brad FitzpatrickandBrad Fitzpatrick	99b06eac49	syncs: add Mutex/RWMutex alias/wrappers for future mutex debugging ... Updates #17852 Change-Id: I477340fb8e40686870e981ade11cd61597c34a20 Signed-off-by: Brad Fitzpatrick <[email protected]>	2025-11-16 19:13:59 -08:00
Jordan WhitedandGitHub	e1f0ad7a05	net/udprelay: implement Server.SetStaticAddrPorts (#17909) ... Only used in tests for now. Updates tailscale/corp#31489 Signed-off-by: Jordan Whited <[email protected]>	2025-11-14 19:43:44 -08:00
Jordan WhitedandGitHub	0285e1d5fb	feature/relayserver: fix Shutdown() deadlock (#17898) ... Updates #17894 Signed-off-by: Jordan Whited <[email protected]>	2025-11-14 10:22:58 -08:00
Jordan WhitedandGitHub	9e4d1fd87f	feature/relayserver,ipn/ipnlocal,net/udprelay: plumb DERPMap (#17881) ... This commit replaces usage of local.Client in net/udprelay with DERPMap plumbing over the eventbus. This has been a longstanding TODO. This work was also accelerated by a memory leak in net/http when using local.Client over long periods of time. So, this commit also addresses said leak. Updates #17801 Signed-off-by: Jordan Whited <[email protected]>	2025-11-13 20:57:48 -08:00
Jordan WhitedandGitHub	e2233b7942	feature/relayserver: init server at config time instead of request time (#17484) ... The lazy init led to confusion and a belief that was something was wrong. It's reasonable to expect the daemon to listen on the port at the time it's configured. Updates tailscale/corp#33094 Signed-off-by: Jordan Whited <[email protected]>	2025-10-09 11:45:03 -07:00
M. J. FrombergerandGitHub	3c32f87624	feature/relayserver: use eventbus.Monitor to simplify lifecycle management (#17234) ... Instead of using separate channels to manage the lifecycle of the eventbus client, use the recently-added eventbus.Monitor, which handles signaling the processing loop to stop and waiting for it to complete. This allows us to simplify some of the setup and cleanup code in the relay server. Updates #15160 Change-Id: Ia1a47ce2e5a31bc8f546dca4c56c3141a40d67af Signed-off-by: M. J. Fromberger <[email protected]>	2025-10-02 09:18:55 -07:00
3 people	4657cbdb11	client, cmd/tailscale/cli, feature/relayserver, net/udprelay: implement tailscale debug peer-relay-sessions (#17239) ... Fixes tailscale/corp#30035 Signed-off-by: Dylan Bargatze <[email protected]> Signed-off-by: Jordan Whited <[email protected]> Co-authored-by: Dylan Bargatze <[email protected]>	2025-09-23 15:26:10 -07:00
M. J. FrombergerandGitHub	8608e42103	feature,ipn/ipnlocal,wgengine: improve how eventbus shutdown is handled (#17156) ... Instead of waiting for a designated subscription to close as a canary for the bus being stopped, use the bus Client's own signal for closure added in #17118. Updates #cleanup Change-Id: I384ea39f3f1f6a030a6282356f7b5bdcdf8d7102 Signed-off-by: M. J. Fromberger <[email protected]>	2025-09-16 10:52:39 -07:00
Jordan WhitedandGitHub	24dd19c9a0	tstest/integration{/testcontrol}: add peer relay integration test (#17103) ... Updates tailscale/corp#30903 Signed-off-by: Jordan Whited <[email protected]>	2025-09-15 16:32:12 -07:00
Jordan WhitedandGitHub	8453170aa1	feature/relayserver: fix consumeEventbusTopics deadlock (#16618) ... consumeEventbusTopics now owns server and related eventbus machinery. Updates tailscale/corp#30651 Signed-off-by: Jordan Whited <[email protected]>	2025-07-21 12:36:16 -07:00
3 people	1677fb1905	wgengine/magicsock,all: allocate peer relay over disco instead of PeerAPI (#16603) ... Updates tailscale/corp#30583 Updates tailscale/corp#30534 Updates tailscale/corp#30557 Signed-off-by: Dylan Bargatze <[email protected]> Signed-off-by: Jordan Whited <[email protected]> Co-authored-by: Dylan Bargatze <[email protected]>	2025-07-21 10:02:37 -07:00
Jordan WhitedandGitHub	bd29a1c8c1	feature/relayserver,wgengine/magicsock: remove WIP gating of peer relay (#16533) ... Updates tailscale/corp#30051 Signed-off-by: Jordan Whited <[email protected]>	2025-07-10 18:52:01 -07:00
Dylan BargatzeandGitHub	92a114c66d	tailcfg, feature/relayserver, wgengine/magicsock: invert UDP relay server nodeAttrs (#16444) ... Inverts the nodeAttrs related to UDP relay client/server enablement to disablement, and fixes up the corresponding logic that uses them. Also updates the doc comments on both nodeAttrs. Fixes tailscale/corp#30024 Signed-off-by: Dylan Bargatze <[email protected]>	2025-07-04 12:48:38 -04:00
Jordan WhitedandGitHub	3a4b439c62	feature/relayserver,net/udprelay: add IPv6 support (#16442) ... Updates tailscale/corp#27502 Updates tailscale/corp#30043 Signed-off-by: Jordan Whited <[email protected]>	2025-07-02 20:38:39 -07:00
Jordan WhitedandGitHub	a589863d61	feature/relayserver,net/udprelay,wgengine/magicsock: implement retry (#16347) ... udprelay.Server is lazily initialized when the first request is received over peerAPI. These early requests have a high chance of failure until the first address discovery cycle has completed. Return an ErrServerNotReady error until the first address discovery cycle has completed, and plumb retry handling for this error all the way back to the client in relayManager. relayManager can now retry after a few seconds instead of waiting for the next path discovery cycle, which could take another minute or longer. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-06-23 15:50:43 -07:00
Jordan WhitedandGitHub	3ed76ceed3	feature/relayserver,net/{netcheck,udprelay}: implement addr discovery (#16253) ... The relay server now fetches IPs from local interfaces and external perspective IP:port's via netcheck (STUN). Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-06-12 09:57:45 -07:00
Jordan WhitedandGitHub	0841477743	net/udprelay{/endpoint}, all: move ServerEndpoint to independent pkg (#15934) ... ServerEndpoint will be used within magicsock and potentially elsewhere, which should be possible without needing to import the server implementation itself. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-05-09 11:29:36 -07:00
Jordan WhitedandGitHub	7e2630235f	feature/relayserver: consider relay:server node attribute for enablement (#15901) ... Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-05-07 09:15:33 -07:00
3 people	068d5ab655	feature/taildrop: move rest of Taildrop out of LocalBackend ... Updates #12614 Change-Id: If451dec1d796f6a4216fe485975c87f0c62a53e5 Signed-off-by: Brad Fitzpatrick <[email protected]> Co-authored-by: Nick Khyl <[email protected]>	2025-05-06 20:41:27 -07:00
Brad FitzpatrickandBrad Fitzpatrick	3bc10ea585	ipn/ipnext: remove some interface indirection to add hooks ... Now that 25c4dc5fd7 removed unregistering hooks and made them into slices, just expose the slices and remove the setter funcs. This removes boilerplate ceremony around adding new hooks. This does export the hooks and make them mutable at runtime in theory, but that'd be a data race. If we really wanted to lock it down in the future we could make the feature.Hooks slice type be an opaque struct with an All() iterator and a "frozen" bool and we could freeze all the hooks after init. But that doesn't seem worth it. This means that hook registration is also now all in one place, rather than being mixed into ProfilesService vs ipnext.Host vs FooService vs BarService. I view that as a feature. When we have a ton of hooks and the list is long, then we can rearrange the fields in the Hooks struct as needed, or make sub-structs, or big comments. Updates #12614 Change-Id: I05ce5baa45a61e79c04591c2043c05f3288d8587 Signed-off-by: Brad Fitzpatrick <[email protected]>	2025-04-25 09:03:39 -07:00
3 people	3d8533b5d0	ipn/{ipnext,ipnlocal}: add a SafeBackend interface ... Updates #12614 Change-Id: I197e673666e86ea74c19e3935ed71aec269b6c94 Co-authored-by: Nick Khyl <[email protected]> Signed-off-by: Brad Fitzpatrick <[email protected]>	2025-04-24 14:48:58 -07:00
Jordan WhitedandGitHub	c28fda864a	feature/relayserver: use PeerAPIHandler.Logf() (#15765) ... This was recently added, use it to be consistent. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-04-22 10:53:58 -07:00
Jordan WhitedandGitHub	92027d7ae0	feature/relayserver: wire up profile/prefs changes (#15714) ... The relay server is still permanently disabled until node attribute changes are wired up in a future commit. Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-04-17 09:24:11 -07:00
Jordan WhitedandGitHub	37f5fd2ec1	feature/{condregister,relayserver}: implement the skeleton for the relayserver feature (#15699) ... This feature is "registered" as an ipnlocal.Extension, and conditionally linked depending on GOOS and ts_omit_relayserver build tag. The feature is not linked on iOS in attempt to limit the impact to binary size and resulting effect of pushing up against NetworkExtension limits. Eventually we will want to support the relay server on iOS, specifically on the Apple TV. Apple TVs are well-fitted to act as underlay relay servers as they are effectively always-on servers. This skeleton begins to tie a PeerAPI endpoint to a net/udprelay.Server. The PeerAPI endpoint is currently no-op as extension.shouldRunRelayServer() always returns false. Follow-up commits will implement extension.shouldRunRelayServer(). Updates tailscale/corp#27502 Signed-off-by: Jordan Whited <[email protected]>	2025-04-16 09:50:48 -07:00