BilalG1 edc68fea58 test fixes (#893) ... <!-- Make sure you've read the CONTRIBUTING.md guidelines: https://github.com/stack-auth/stack-auth/blob/dev/CONTRIBUTING.md --> <!-- RECURSEML_SUMMARY:START --> ## High-level PR Summary This PR improves email testing in the end-to-end test suite by adding a new `waitForMessagesWithSubject` helper method to the `Mailbox` class. This method replaces the previous pattern of using arbitrary wait times (e.g., `wait(2000)`) followed by fetching and finding messages, which could lead to flaky tests. The new approach implements a polling mechanism that waits until messages with the specified subject appear, with a reasonable timeout. The PR updates all email-related tests to use this new helper method, making the tests more reliable and less dependent on timing assumptions. ⏱️ Estimated Review Time: 0h 15m <details> <summary>💡 Review Order Suggestion</summary> | Order | File Path | |-------|-----------| | 1 | `apps/e2e/tests/helpers.ts` | | 2 | `apps/e2e/tests/backend/endpoints/api/v1/send-email.test.ts` | | 3 | `apps/e2e/tests/backend/endpoints/api/v1/unsubscribe-link.test.ts` | </details> <!-- RECURSEML_SUMMARY:END --> <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Improves email test reliability by adding `waitForMessagesWithSubject` in `Mailbox` and updating tests to use it. > > - **Behavior**: > - Introduces `waitForMessagesWithSubject` in `Mailbox` class in `helpers.ts` to replace arbitrary wait times with a polling mechanism. > - Updates email-related tests in `send-email.test.ts` and `unsubscribe-link.test.ts` to use `waitForMessagesWithSubject` for more reliable email verification. > - **Tests**: > - Replaces `wait()` calls with `waitForMessagesWithSubject()` in `send-email.test.ts` and `unsubscribe-link.test.ts`. > - Ensures emails are verified by subject, reducing flakiness in tests. > - **Misc**: > - Minor refactoring in `helpers.ts` to support new functionality. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=stack-auth%2Fstack-auth&utm_source=github&utm_medium=referral)<sup> for 90b7bdad01. You can [customize](https://app.ellipsis.dev/stack-auth/settings/summaries) this summary. It will automatically update as commits are pushed.</sup> ---- <!-- ELLIPSIS_HIDDEN --> <!-- RECURSEML_ANALYSIS:START --> ## Review by RecurseML _🔍 Review performed on [d14317c..f42dfc5](d14317c787...f42dfc5351)_ | Severity | Location | Issue | Action | |----------|----------|-------|--------| |  | [apps/e2e/tests/helpers.ts:235](https://github.com/stack-auth/stack-auth/pull/893#discussion_r2342704515) | Async function call not wrapped with runAsynchronously | [ | <details> <summary>✅ Files analyzed, no issues (2)</summary> • `apps/e2e/tests/backend/endpoints/api/v1/send-email.test.ts` • `apps/e2e/tests/backend/endpoints/api/v1/unsubscribe-link.test.ts` </details> [](https://discord.gg/n3SsVDAW6U) <!-- RECURSEML_ANALYSIS:END --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * More reliable email end-to-end tests by waiting for messages by subject instead of fixed delays and manual polling. * Multi-recipient scenarios now independently confirm delivery for each user. * Switched to snapshot-style assertions capturing full message metadata for clearer, more stable verification. * Unsubscribe email tests now wait deterministically for delivery before validating links. * **Chores** * Mailbox handling improved to reduce flakiness and repeated network calls. <!-- end of auto-generated comment: release notes by coderabbit.ai -->		2025-09-12 10:41:53 -07:00
..
backend	test fixes (#893)	2025-09-12 10:41:53 -07:00
general	Reduce test flakeyness (#517)	2025-03-07 13:34:50 -08:00
js	Email Drafts (#849)	2025-09-10 22:57:18 +00:00
global-setup.ts	Disallow trailing spaces	2024-07-14 10:35:33 -07:00
globals.d.ts	Upgrade backend to Next.js 15 (#360)	2024-12-10 00:11:13 -08:00
helpers.ts	test fixes (#893)	2025-09-12 10:41:53 -07:00
setup.ts	JWKS endpoint now uses base64url	2024-10-11 17:09:24 -07:00
snapshot-serializer.ts	Include primary email and display name in JWT	2025-09-09 11:06:47 -07:00