BilalG1 e7f2cc8d8d fix one-time-stackable (#925) ... <!-- Make sure you've read the CONTRIBUTING.md guidelines: https://github.com/stack-auth/stack-auth/blob/dev/CONTRIBUTING.md --> <!-- RECURSEML_SUMMARY:START --> ## High-level PR Summary This PR fixes a bug in the one-time purchase validation logic by allowing stackable offers to be purchased multiple times. Previously, the system blocked duplicate one-time purchases regardless of whether the offer was marked as stackable. The fix adds a check to only prevent duplicate purchases when the offer's `stackable` property is not `true`, enabling customers to purchase stackable offers more than once. ⏱️ Estimated Review Time: 15-30 minutes <details> <summary>💡 Review Order Suggestion</summary> | Order | File Path | |-------|-----------| | 1 | `apps/backend/src/lib/payments.tsx` | | 2 | `apps/backend/src/lib/payments.test.tsx` | </details> [](https://discord.gg/n3SsVDAW6U) <!-- RECURSEML_SUMMARY:END --> <!-- ELLIPSIS_HIDDEN --> ---- > [!IMPORTANT] > Fixes purchase validation to allow multiple purchases of stackable products and updates tests accordingly. > > - **Behavior**: > - Fixes bug in `validatePurchaseSession` in `payments.tsx` to allow multiple purchases of stackable products. > - Updates error message for non-stackable products to "Customer already has purchased this product; this product is not stackable". > - **Tests**: > - Adds test cases in `payments.test.tsx` to verify stackable and non-stackable purchase logic. > - Ensures stackable products can be purchased multiple times, while non-stackable products cannot. > - **Misc**: > - Minor updates to error messages and test descriptions for clarity. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=stack-auth%2Fstack-auth&utm_source=github&utm_medium=referral)<sup> for 113d035b35. You can [customize](https://app.ellipsis.dev/stack-auth/settings/summaries) this summary. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Improved default product handling per catalog with clear errors when multiple defaults are configured. - Bug Fixes - Unified validation for non-stackable products across subscriptions and one-time purchases, preventing duplicate ownership. - Standardized error message when attempting to repurchase a non-stackable product: “Customer already has purchased this product; this product is not stackable”. - Tests - Updated unit and end-to-end tests to reflect non-stackable product behavior and the new error messaging. - Adjusted scenarios and expectations around default product selection and duplicate purchase blocking. <!-- end of auto-generated comment: release notes by coderabbit.ai -->		2025-10-07 10:37:02 -07:00
..
tests	fix one-time-stackable (#925)	2025-10-07 10:37:02 -07:00
.env	Auto migration (#526)	2025-07-24 02:38:37 +02:00
.env.development	Auto migration (#526)	2025-07-24 02:38:37 +02:00
.eslintrc.cjs	tsup for stack-shared (#647)	2025-04-28 21:26:52 -07:00
CHANGELOG.md	chore: update package versions	2025-09-26 23:16:39 -05:00
LICENSE	Create users & auth endpoints in backend (#85)	2024-07-01 22:42:08 -07:00
package.json	chore: update package versions	2025-09-26 23:16:39 -05:00
tsconfig.json	In-source unit tests (#429)	2025-02-14 11:47:52 -08:00
vitest.config.ts	Endpoints branching (#659)	2025-04-30 15:39:47 -07:00