mirror of
https://github.com/stack-auth/stack.git
synced 2026-06-30 21:01:54 +08:00
## Stack Auth → Hexclave rename — PR 5 (internal symbols, paths,
packages, brand strings)
PR 5 finishes the **internal / non-wire** half of the Stack→Hexclave
rename. It only touches things where nothing outside the repo depends on
the exact name: internal symbols, file/dir names, the
`@stackframe/template` package, and residual brand strings. Plan +
progress are in `HEXCLAVE-RENAME-PR5-PLAN.md`.
Every step was verified green (`pnpm typecheck` + `pnpm lint`, 28/28)
and committed as its own checkpoint, then a fan-out of review agents
audited all commits and the findings were fixed.
### What changed
- **Internal symbols** (`@hexclave/shared`, `packages/template`, apps):
`stack*`/`Stack*` → `hexclave*`/`Hexclave*` — incl.
`stackGlobalsSymbol`, the `_Stack*AppImpl` classes,
`stackAppInternalsSymbol`, `StackContext`, `getStackStripe`, etc. The
`stack*App` local-variable convention
(`stackServerApp`/`stackClientApp`/…) was renamed across 175
source/example/doc files.
- **File renames**: `hexclave-handler/provider/context.tsx`,
`backend/hexclave.tsx`, `internal-tool/hexclave.ts`,
`hexclave-app-internals.ts`.
- **Directory renames**: `lib/hexclave-app`, `hexclave-companion`,
`[...hexclave]` route segment, `skills/hexclave`,
`dashboard/src/hexclave`, and the package dirs
**`packages/{next,shared,ui,sc,cli}`** (dropping the `stack-` prefix to
match the `@hexclave/*` npm names).
- **Packages**: `@stackframe/template` → `@hexclave/template`; **deleted
`packages/init-stack`** (onboarding lives in `@hexclave/cli init`; the
published npm package is untouched).
- **Brand strings**: reworded `Stack Auth`/`Stack dashboard` prose in
code + docs-mintlify, renamed `hexclave-app.mdx`/`use-hexclave-app.mdx`
with redirects, regenerated OpenAPI, updated coupled e2e assertions;
`doctor`/`init` now prefer `hexclave.config.ts`.
### Intentionally kept (verified, not oversights)
Wire/compat identifiers (`x-stack-*` headers, `stack-*` cookies,
`STACK_*` env names, `*.stack-auth.com`, `stackauth_`, `ask_stack_auth`,
query params), public `Stack*` SDK aliases, crypto/JWT/vault
domain-separation tags, `*-brand-sentinel`s, the
`Symbol.for("StackAuth--…")` string, `_stack_sync_metadata`, Postgres
`stackframe` / docker image names, the `stack-auth-logo*.svg` (used by
the rebrand modal), and `migration.mdx` / "formerly known as Stack Auth"
notes. False positives (Phosphor `StackIcon`/`StackSimple`, `TanStack`,
`OrbStack`, `stackable`/`Stacked` charts) left alone.
### Review pass
Six review agents audited all commits. Found + fixed one real bug — a
build script (`bundle-type-definitions.ts`) hardcoded the old
`lib/stack-app` glob path (not an import, so typecheck/lint were blind),
silently emptying the dashboard AI type bundle — plus stale comments, a
dead CI env var, and stale `.gitignore`/`.dockerignore` entries.
Cross-cutting audit confirmed **zero wire-compat identifiers were
accidentally renamed**.
### ⚠️ Verification note
`typecheck` + `lint` are fully green locally. The **e2e suite was not
run** (needs a live backend+DB), so the brand-string assertion +
OpenAPI-regen changes are verified by grep/codegen only — please let CI
exercise e2e to confirm.
### Base-branch note
This branch was forked from the local-only `cl/friendly-lewin-72293f`
(not on origin, no separate PR), so this PR against `dev` also carries
that branch's ~11 preceding Hexclave-rename commits (config-file rename,
env-var dual-read, AI setup-prompt rebrand). If those should land
separately, re-parent before merge.
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Finishes the internal Stack Auth → Hexclave rename and cleans up
remaining stragglers, including dev-tool and prompt copy. All changes
are internal-only; public/wire APIs remain unchanged. Re-merged `dev`
and resolved the payments create-purchase-url conflict.
- **Refactors**
- Internal symbols: stack*/Stack* → hexclave*/Hexclave* (e.g.,
`getHexclaveServerApp` via `@/hexclave`, `getHexclaveStripe`,
`hexclaveAppInternalsSymbol`, `hexclaveSchemaInfo`, Prisma
`__hexclave_*`, `data-hexclave-handler-page`, Stripe mock
`hexclavePortPrefix`).
- Files/dirs: moved to `lib/hexclave-app`; handler route
`[...hexclave]`; backend entry `src/hexclave.tsx`; dashboard internals
`hexclave-app-internals`; companion `hexclave-companion`; dropped
`stack-` prefix across package dirs
(`packages/{shared,ui,sc,cli,next}`); workflows/emulator paths now
`packages/cli`; Quetzal codegen env at `packages/next/.env.local`.
- Packages/docs: `@stackframe/template` → `@hexclave/template`; removed
`packages/init-stack`; regenerated OpenAPI and updated docs
slugs/redirects for hexclave-app/use-hexclave-app.
- Brand strings/prompts: reworded remaining “Stack” dashboard strings to
Hexclave; updated dev-tool copy and prompts; `doctor/init` now prefer
`hexclave.config.ts`. Kept all wire-compat identifiers and public
aliases (`x-stack-*`, `stack-*` cookies, `STACK_*` env,
`*.stack-auth.com`, `Stack*` SDK names).
- Rebased/merged onto latest `dev`: retained `@hexclave/template`, kept
`src` in published files, refreshed setup-prompt imports and docs JSON,
adopted 1.0.5 version bumps, and re-merged `dev` again (resolved
`create-purchase-url` with `getHexclaveStripe`).
- **Bug Fixes**
- Restored dashboard AI type bundle by pointing the glob to
`packages/template/src/lib/hexclave-app`.
- Addressed rename leftovers: updated lingering `@/stack` imports and
CSS selector, fixed schema/meta and port-prefix expansions, and aligned
emulator commands to `packages/cli`.
- CI/build: removed a dead env var and stale ignore entries; fixed
Docker by renaming `STACK_SKIP_TEMPLATE_GENERATION` →
`HEXCLAVE_SKIP_TEMPLATE_GENERATION`.
<sup>Written for commit 3c1af3bff3.
Summary will update on new commits.</sup>
<a
href="https://cubic.dev/pr/hexclave/hexclave/pull/1547?utm_source=github"
target="_blank" rel="noopener noreferrer"
data-no-image-dialog="true"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cubic.dev/buttons/review-in-cubic-dark.svg"><source
media="(prefers-color-scheme: light)"
srcset="https://cubic.dev/buttons/review-in-cubic-light.svg"><img
alt="Review in cubic"
src="https://cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->
254 lines
6.5 KiB
TypeScript
254 lines
6.5 KiB
TypeScript
import { describe, expect, test } from "vitest";
|
|
import { NicifyOptions, deindent, nicify } from "./strings";
|
|
|
|
describe("nicify", () => {
|
|
describe("primitive values", () => {
|
|
test("numbers", () => {
|
|
expect(nicify(123)).toBe("123");
|
|
expect(nicify(123n)).toBe("123n");
|
|
});
|
|
|
|
test("strings", () => {
|
|
expect(nicify("hello")).toBe('"hello"');
|
|
});
|
|
|
|
test("booleans", () => {
|
|
expect(nicify(true)).toBe("true");
|
|
expect(nicify(false)).toBe("false");
|
|
});
|
|
|
|
test("null and undefined", () => {
|
|
expect(nicify(null)).toBe("null");
|
|
expect(nicify(undefined)).toBe("undefined");
|
|
});
|
|
|
|
test("symbols", () => {
|
|
expect(nicify(Symbol("test"))).toBe("Symbol(test)");
|
|
});
|
|
});
|
|
|
|
describe("arrays", () => {
|
|
test("empty array", () => {
|
|
expect(nicify([])).toBe("[]");
|
|
});
|
|
|
|
test("single-element array", () => {
|
|
expect(nicify([1])).toBe("[1]");
|
|
});
|
|
|
|
test("single-element array with long content", () => {
|
|
expect(nicify(["123123123123123"])).toBe('["123123123123123"]');
|
|
});
|
|
|
|
test("flat array", () => {
|
|
expect(nicify([1, 2, 3])).toBe("[1, 2, 3]");
|
|
});
|
|
|
|
test("longer array", () => {
|
|
expect(nicify([10000, 2, 3])).toBe(deindent`
|
|
[
|
|
10000,
|
|
2,
|
|
3,
|
|
]
|
|
`);
|
|
});
|
|
|
|
test("nested array", () => {
|
|
expect(nicify([1, [2, 3]])).toBe(deindent`
|
|
[
|
|
1,
|
|
[2, 3],
|
|
]
|
|
`);
|
|
});
|
|
});
|
|
|
|
describe("objects", () => {
|
|
test("empty object", () => {
|
|
expect(nicify({})).toBe("{}");
|
|
});
|
|
|
|
test("simple object", () => {
|
|
expect(nicify({ a: 1 })).toBe('{ "a": 1 }');
|
|
});
|
|
|
|
test("multiline object", () => {
|
|
expect(nicify({ a: 1, b: 2 })).toBe(deindent`
|
|
{
|
|
"a": 1,
|
|
"b": 2,
|
|
}
|
|
`);
|
|
});
|
|
});
|
|
|
|
describe("custom classes", () => {
|
|
test("class instance", () => {
|
|
class TestClass {
|
|
constructor(public value: number) {}
|
|
}
|
|
expect(nicify(new TestClass(42))).toBe('TestClass { "value": 42 }');
|
|
});
|
|
});
|
|
|
|
describe("built-in objects", () => {
|
|
test("URL", () => {
|
|
expect(nicify(new URL("https://example.com"))).toBe('URL("https://example.com/")');
|
|
});
|
|
|
|
test("TypedArrays", () => {
|
|
expect(nicify(new Uint8Array([1, 2, 3]))).toBe("Uint8Array([1,2,3])");
|
|
expect(nicify(new Int32Array([1, 2, 3]))).toBe("Int32Array([1,2,3])");
|
|
});
|
|
|
|
test("Error objects", () => {
|
|
const error = new Error("test error");
|
|
const nicifiedError = nicify({ error });
|
|
expect(nicifiedError).toMatch(new RegExp(deindent`
|
|
^\{
|
|
"error": Error: test error
|
|
Stack:
|
|
at (.|\\n)*
|
|
\}$
|
|
`));
|
|
});
|
|
|
|
test("Error objects with cause and an extra property", () => {
|
|
const error = new Error("test error", { cause: new Error("cause") });
|
|
(error as any).extra = "something";
|
|
const nicifiedError = nicify(error, { lineIndent: "--" });
|
|
expect(nicifiedError).toMatch(new RegExp(deindent`
|
|
^Error: test error
|
|
--Stack:
|
|
----at (.|\\n)+
|
|
--Extra properties: \{ "extra": "something" \}
|
|
--Cause:
|
|
----Error: cause
|
|
------Stack:
|
|
--------at (.|\\n)+$
|
|
`));
|
|
});
|
|
|
|
test("Headers", () => {
|
|
const headers = new Headers();
|
|
headers.append("Content-Type", "application/json");
|
|
headers.append("Accept", "text/plain");
|
|
expect(nicify(headers)).toBe(deindent`
|
|
Headers {
|
|
"accept": "text/plain",
|
|
"content-type": "application/json",
|
|
}`
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("multiline strings", () => {
|
|
test("basic multiline", () => {
|
|
expect(nicify("line1\nline2")).toBe('deindent`\n line1\n line2\n`');
|
|
});
|
|
|
|
test("multiline with trailing newline", () => {
|
|
expect(nicify("line1\nline2\n")).toBe('deindent`\n line1\n line2\n` + "\\n"');
|
|
});
|
|
|
|
test("multiline with dollar sign", () => {
|
|
expect(nicify("a\n$b\nc")).toBe('deindent`\n a\n $b\n c\n`');
|
|
});
|
|
|
|
test("multiline with dollar sign interpolation", () => {
|
|
expect(nicify("a\n${b\nc")).toBe('deindent`\n a\n \\${b\n c\n`');
|
|
});
|
|
});
|
|
|
|
describe("circular references", () => {
|
|
test("object with self reference", () => {
|
|
const circular: any = { a: 1 };
|
|
circular.self = circular;
|
|
expect(nicify(circular)).toBe(deindent`
|
|
{
|
|
"a": 1,
|
|
"self": Ref<value>,
|
|
}`
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("configuration options", () => {
|
|
test("maxDepth", () => {
|
|
const deep = { a: { b: { c: { d: { e: 1 } } } } };
|
|
expect(nicify(deep, { maxDepth: 2 })).toBe('{ "a": { "b": { ... } } }');
|
|
});
|
|
|
|
test("lineIndent", () => {
|
|
expect(nicify({ a: 1, b: 2 }, { lineIndent: " " })).toBe(deindent`
|
|
{
|
|
"a": 1,
|
|
"b": 2,
|
|
}
|
|
`);
|
|
});
|
|
|
|
test("hideFields", () => {
|
|
expect(nicify({ a: 1, b: 2, secret: "hidden" }, { hideFields: ["secret"] })).toBe(deindent`
|
|
{
|
|
"a": 1,
|
|
"b": 2,
|
|
<some fields may have been hidden>,
|
|
}
|
|
`);
|
|
});
|
|
});
|
|
|
|
describe("custom overrides", () => {
|
|
test("override with custom type", () => {
|
|
expect(nicify({ type: "special" }, {
|
|
overrides: ((value: unknown) => {
|
|
if (typeof value === "object" && value && "type" in value && (value as any).type === "special") {
|
|
return "SPECIAL";
|
|
}
|
|
return null;
|
|
}) as NicifyOptions["overrides"]
|
|
})).toBe("SPECIAL");
|
|
});
|
|
});
|
|
|
|
describe("functions", () => {
|
|
test("named function", () => {
|
|
expect(nicify(function namedFunction() {})).toBe("function namedFunction(...) { ... }");
|
|
});
|
|
|
|
test("arrow function", () => {
|
|
expect(nicify(() => {})).toBe("(...) => { ... }");
|
|
});
|
|
});
|
|
|
|
describe("Nicifiable interface", () => {
|
|
test("object implementing Nicifiable", () => {
|
|
const nicifiable = {
|
|
value: 42,
|
|
getNicifiableKeys() {
|
|
return ["value"];
|
|
},
|
|
getNicifiedObjectExtraLines() {
|
|
return ["// custom comment"];
|
|
}
|
|
};
|
|
expect(nicify(nicifiable)).toBe(deindent`
|
|
{
|
|
"value": 42,
|
|
// custom comment,
|
|
}
|
|
`);
|
|
});
|
|
});
|
|
|
|
describe("unknown types", () => {
|
|
test("object without prototype", () => {
|
|
const unknownType = Object.create(null);
|
|
unknownType.value = "test";
|
|
expect(nicify(unknownType)).toBe('{ "value": "test" }');
|
|
});
|
|
});
|
|
});
|