mirror of
https://github.com/stack-auth/stack.git
synced 2026-07-20 21:29:36 +08:00
33a7ef5485
## Problem On a customer's payments view, submitting a manual item quantity change makes the "New balance: X → Y" preview in the dialog briefly flip to the post-change values (e.g. `0 → 10` flashes to `10 → 20`) right before the dialog closes. ## Root cause The preview was computed from the live `currentQuantity` prop, which comes from `useItem()` in the parent row. The SDK's `createItemQuantityChange` awaits its item cache refresh before resolving, so the prop updates to the new quantity while the dialog is still open (and stays visible through the close animation), recomputing the preview with stale input text. ## Fix Snapshot the quantity when the dialog opens (in the existing reset-on-open effect) and compute the preview from the snapshot instead of the live prop. The preview now consistently shows the balance as of when the dialog was opened. ## Before vs after Recorded against built servers (before = `dev`, after = this branch). The transactions refetch is artificially delayed by 5s in both recordings to stretch the flicker window to a visible length — on production latency it's a split-second flash. https://github.com/user-attachments/assets/c005ef3b-45cb-4b75-bd71-5f723eae0c50 ## Tradeoffs If the quantity changes externally while the dialog is open, the preview shows the value from open time. The mutation is a delta, so correctness of the applied change is unaffected. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Stabilized the quantity change preview while the dialog is open. * The “New balance” display now consistently shows the quantity at opening and the calculated updated quantity, even if underlying values change during submission. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| public | ||
| scripts | ||
| src | ||
| .env | ||
| .env.development | ||
| .eslintrc.cjs | ||
| .gitignore | ||
| .npmrc | ||
| components.json | ||
| DESIGN-GUIDE.md | ||
| instrumentation-client.ts | ||
| LICENSE | ||
| next.config.mjs | ||
| package.json | ||
| postcss.config.js | ||
| tailwind.config.ts | ||
| tsconfig.json | ||
| vitest.config.ts | ||