CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-13 21:01:21 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Remove GitHub OAuth provider error noise

Browse Source
This commit is contained in:
Konstantin Wohlwend 2026-05-26 13:31:14 -07:00 committed by Madison
parent 3a3f3e359b
commit f42c08192a
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/backend/src/oauth/providers/base.tsx
View File

@ -272,15 +272,8 @@ function processTokenSet(providerName: string, tokenSet: OIDCTokenSet, defaultAc
// one-hour fallback and capture telemetry.
const defaultExpiresInMillis = typeof defaultAccessTokenExpiresInMillis === "function" ? defaultAccessTokenExpiresInMillis(tokenSet) : defaultAccessTokenExpiresInMillis;
const hasInvalidProviderExpiry =
(tokenSet.expires_in != null && getFiniteNumber(tokenSet.expires_in) === undefined)
|| (tokenSet.expires_at != null && getFiniteNumber(tokenSet.expires_at) === undefined);
if (hasInvalidProviderExpiry) {
captureError("processTokenSet", new HexclaveAssertionError(`Invalid expires_in or expires_at received from OAuth provider ${providerName}. Falling back to provider/default expiry handling`, { tokenSetKeys: Object.keys(tokenSet) }));
}
if (getFiniteNumber(tokenSet.expires_in) === undefined && getFiniteNumber(tokenSet.expires_at) === undefined && defaultExpiresInMillis === undefined) {
captureError("processTokenSet", new HexclaveAssertionError(`No expires_in or expires_at received from OAuth provider ${providerName}. Falling back to 1h`, { tokenSetKeys: Object.keys(tokenSet) }));
captureError("processTokenSet", new HexclaveAssertionError(`No valid expires_in or expires_at received from OAuth provider ${providerName}. This provider might not support expires_at, so please add a fallback for this provider based on the information from its documentation (eg. GitHub does not return JWT access tokens so we can't know the actual expiry of the token). Falling back to 1h`, { tokenSetKeys: Object.keys(tokenSet) }));
}
return {