CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-13 21:01:21 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

More descriptive error message when invalid scopes are requested

Browse Source
This commit is contained in:
Konstantin Wohlwend 2025-01-13 10:25:07 -08:00
parent ff7c72798b
commit f15de038fe
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/backend/src/app/api/v1/auth/oauth/callback/[provider_id]/route.tsx
View File

@ -11,7 +11,7 @@ import { KnownError, KnownErrors } from "@stackframe/stack-shared";
import { ProjectsCrud } from "@stackframe/stack-shared/dist/interface/crud/projects";
import { yupMixed, yupNumber, yupObject, yupString } from "@stackframe/stack-shared/dist/schema-fields";
import { StackAssertionError, StatusError, captureError } from "@stackframe/stack-shared/dist/utils/errors";
import { extractScopes } from "@stackframe/stack-shared/dist/utils/strings";
import { deindent, extractScopes } from "@stackframe/stack-shared/dist/utils/strings";
import { cookies } from "next/headers";
import { redirect } from "next/navigation";
import { oauthResponseToSmartResponse } from "../../oauth-helpers";
@ -326,7 +326,11 @@ const handler = createSmartRouteHandler({
// which scopes are being requested, and by whom?
// I think this is a bug in the client? But just to be safe, let's log an error to make sure that it is not our fault
// TODO: remove the captureError once you see in production that our own clients never trigger this
captureError("outer-oauth-callback-invalid-scope", new StackAssertionError("A client requested an invalid scope. Is this a bug in the client, or our fault?", { outerInfo, cause: error }));
captureError("outer-oauth-callback-invalid-scope", new StackAssertionError(deindent`
A client requested an invalid scope. Is this a bug in the client, or our fault?
Scopes requested: ${oauthRequest.query?.scope}
`, { outerInfo, cause: error, scopes: oauthRequest.query?.scope }));
throw new StatusError(400, "Invalid scope requested. Please check the scopes you are requesting.");
}
throw error;