CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-04 21:04:37 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: align manager.ts with dev — use replaceConfigObject + override instead of updateConfigObject

Browse Source 
The merge auto-resolved manager.ts by keeping the updateConfigObject import,
but dev switched to the simpler replaceConfigObject + override approach. The
transitive import chain through updateConfigObject pulled the Claude agent SDK
into the Edge Runtime bundle, causing Turbopack build failures (crypto, fs,
path, process.exit are not available in Edge Runtime).

Co-Authored-By: mantra <mantra@stack-auth.com>
This commit is contained in:
Devin AI 2026-06-03 19:23:32 +00:00
parent 6cdb123395
commit eed199d430
1 changed files with 15 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
apps/dashboard/src/lib/remote-development-environment/manager.ts
View File

@ -3,7 +3,7 @@ import "server-only";
import { getPublicEnvVar } from "@/lib/env";
import { stackAppInternalsSymbol } from "@/lib/stack-app-internals";
import { AdminOwnedProject, StackClientApp } from "@hexclave/next";
import { Config } from "@hexclave/shared/dist/config/format";
import { Config, override } from "@hexclave/shared/dist/config/format";
import { ProjectOnboardingStatus } from "@hexclave/shared/dist/schema-fields";
import { AccessToken } from "@hexclave/shared/dist/sessions";
import { errorToNiceString } from "@hexclave/shared/dist/utils/errors";
@ -16,7 +16,7 @@ import {
readConfigFile,
resolveConfigFilePath,
sha256String,
updateConfigObject,
replaceConfigObject,
} from "./config-file";
import { assertRemoteDevelopmentEnvironmentEnabled } from "./env";
import {
@ -646,29 +646,19 @@ export async function applyRemoteDevelopmentEnvironmentConfigUpdate(options: {
projectId: options.projectId,
configFilePath,
});
// Suppress watcher-driven syncs for the whole (potentially slow, AI-driven,
// multi-file) update so we never sync a partially-edited intermediate state.
// The membership is held until the update resolves and then cleared after a
// debounce so the file-change events our own edits produce are ignored too.
state.synchronouslyUpdatingConfigFiles.add(configFilePath);
let updateSucceeded = false;
try {
await updateConfigObject(configFilePath, options.configUpdate);
updateSucceeded = true;
} finally {
setTimeout(() => {
state.synchronouslyUpdatingConfigFiles.delete(configFilePath);
// For fire-and-forget updates the sync is scheduled only after the
// suppression window clears, otherwise scheduleSync would be swallowed
// by its own guard while the path is still marked as synchronously
// updating. Only sync a successful update: a failed one is rolled back,
// so there is nothing new to push.
if (options.waitForSync === false && updateSucceeded) {
scheduleSync(configFilePath);
}
}, SYNC_DEBOUNCE_MS).unref();
}
if (options.waitForSync !== false) {
const currentConfig = (await readConfigFile(configFilePath)).config;
if (options.waitForSync === false) {
await replaceConfigObject(configFilePath, override(currentConfig, options.configUpdate));
scheduleSync(configFilePath);
} else {
state.synchronouslyUpdatingConfigFiles.add(configFilePath);
try {
await replaceConfigObject(configFilePath, override(currentConfig, options.configUpdate));
} finally {
setTimeout(() => {
state.synchronouslyUpdatingConfigFiles.delete(configFilePath);
}, SYNC_DEBOUNCE_MS).unref();
}
await syncConfigToRemoteNow(configFilePath);
}
logRemoteDevelopmentEnvironment("Applied config update from local dashboard", {