From dad5ceddb43e0445a5fa72c88c9b76b62facbc51 Mon Sep 17 00:00:00 2001 From: armaan Date: Tue, 23 Jun 2026 21:08:29 +0000 Subject: [PATCH] fix: use bounds-checked as T instead of ?? throwErr for nullish-safe mapWithConcurrency Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --- packages/shared/src/utils/promises.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/shared/src/utils/promises.tsx b/packages/shared/src/utils/promises.tsx index 2c69fb5d2..36f7c77c1 100644 --- a/packages/shared/src/utils/promises.tsx +++ b/packages/shared/src/utils/promises.tsx @@ -1,6 +1,6 @@ import { KnownError } from ".."; import { getProcessEnv } from "./env"; -import { HexclaveAssertionError, captureError, concatStacktraces, errorToNiceString, throwErr } from "./errors"; +import { HexclaveAssertionError, captureError, concatStacktraces, errorToNiceString } from "./errors"; import { DependenciesMap } from "./maps"; import { Result } from "./results"; import { traceSpan } from "./telemetry"; @@ -461,7 +461,8 @@ export async function mapWithConcurrency( const index = nextIndex++; if (index >= items.length) return; try { - results[index] = await fn(items[index] ?? throwErr(`mapWithConcurrency: index ${index} out of bounds for items of length ${items.length}`), index); + // Bounds-checked above; `?? throwErr(…)` is unsuitable because T may legitimately be null/undefined + results[index] = await fn(items[index] as T, index); } catch (error) { aborted = true; throw error;