CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-04 21:04:37 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Stricter expectToBeSignedIn

Browse Source
This commit is contained in:
Konstantin Wohlwend 2024-08-22 20:27:52 -07:00
parent 2c55d689a9
commit b119b7a640
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apps/e2e/tests/backend/backend-helpers.ts
View File

@ -172,14 +172,18 @@ export namespace Auth {
/**
* Valid session & valid access token: OK
* Valid session & invalid access token: Error
* Invalid session & valid access token: OK
* Invalid session & valid access token: Error
* Invalid session & invalid access token: Error
*
* (see comment in the function for rationale, and why "invalid refresh token but valid access token" is not
* considered "signed in")
*/
export async function expectToBeSignedIn() {
// there is a world where we would consider "session is valid BUT access token is not" to be "signed in"
// however, it's better to be strict and throw an error regardless
// there is a world where we would accept either access token OR session to be "signed in", instead of both
// however, it's better to be strict and throw an error if either is invalid; this helps catch bugs
// if you really want to check only one of them, use expectSessionToBeValid or expectAccessTokenToBeValid
// for more information, see the comment in expectToBeSignedOut
await Auth.expectAccessTokenToBeValid();
await Auth.expectSessionToBeValid();
}