CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-13 21:01:21 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix emulator pull --pr/--run snapshot detection

Browse Source 
First downloadArtifactByName already extracts both qcow2 and savevm.zst
from the single qemu-emulator-${arch} artifact; the second lookup for a
nonexistent -savevm artifact always failed and produced a misleading
'fast-start disabled' message.
This commit is contained in:
Bilal Godil 2026-04-15 13:59:38 -07:00
parent 0c0d726b28
commit b03486e1c8
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/stack-cli/src/commands/emulator.ts
View File

@ -518,17 +518,13 @@ export function registerEmulatorCommand(program: Command) {
}
if (!existsSync(dest)) throw new CliError(`Expected image not found at ${dest} after download.`);
console.log(`Downloaded: ${dest}`);
// Snapshot artifact is optional — older CI builds may not produce it.
let snapshotDownloaded = false;
try {
snapshotDownloaded = await downloadArtifactByName(repo, runId, `qemu-emulator-${arch}-savevm`, imageDir);
} catch (err) {
console.log(`Snapshot artifact unavailable for run ${runId}: ${err instanceof Error ? err.message : err}`);
}
if (snapshotDownloaded && existsSync(snapshotDest)) {
// CI publishes both files inside the single qemu-emulator-${arch}
// artifact, so the first download already extracts the snapshot when
// present. Older builds may not include it.
if (existsSync(snapshotDest)) {
console.log(`Downloaded: ${snapshotDest}`);
} else if (!snapshotDownloaded) {
console.log(`Snapshot artifact not available for run ${runId}; fast-start disabled.`);
} else {
console.log(`Snapshot not present in artifact for run ${runId}; fast-start disabled.`);
}
} else {
await pullRelease(arch, { repo, branch: opts.branch, tag: opts.tag });