CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-07-20 21:29:36 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Condense snapshot comments in item quantity change dialog

Browse Source
This commit is contained in:
Bilal Godil 2026-07-16 17:22:22 -07:00
parent 1c049e3bd1
commit afaaf790ba
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apps/dashboard/src/components/payments/item-quantity-change-dialog.tsx
View File

@ -44,11 +44,9 @@ export function ItemQuantityChangeDialog(props: Props) {
const [description, setDescription] = useState("");
const [error, setError] = useState<string | null>(null);
const [isSubmitting, setIsSubmitting] = useState(false);
// Snapshot of the quantity at the moment the dialog was opened. The live
// prop updates as soon as the SDK refreshes the item cache after a
// successful submit — i.e. while the dialog is still open (and during its
// close animation) — which would make the "X → Y" preview flicker to the
// post-change values right before closing.
// Snapshot the quantity at dialog open: the live prop updates mid-submit
// (the SDK refreshes the item cache before resolving), which would flip the
// "X → Y" preview to the post-change values right before the dialog closes.
const [quantityAtOpen, setQuantityAtOpen] = useState(props.currentQuantity);
// Reset the form whenever the dialog is (re)opened so stale input doesn't
@ -60,9 +58,7 @@ export function ItemQuantityChangeDialog(props: Props) {
setError(null);
setQuantityAtOpen(props.currentQuantity);
}
// We intentionally only re-snapshot on open, not when currentQuantity
// changes while the dialog is already showing.
// eslint-disable-next-line react-hooks/exhaustive-deps
// eslint-disable-next-line react-hooks/exhaustive-deps -- snapshot only on open
}, [props.open]);
const parsedQuantity = parseQuantityChange(quantityText);