Don't retry transactions during development

apps/backend/src/prisma-client.tsx

@@ -19,6 +19,8 @@ if (getNodeEnvironment() !== 'production') {
 
 
 export async function maybeTransactionWithRetry<T>(fn: (...args: Parameters<Parameters<typeof prismaClient.$transaction>[0]>) => Promise<T>): Promise<T> {
+  const isDev = getNodeEnvironment() === 'development';
+
   const res = await Result.retry(async () => {
     try {
       return Result.ok(await prismaClient.$transaction(fn));
@@ -29,14 +31,17 @@ export async function maybeTransactionWithRetry<T>(fn: (...args: Parameters<Para
       }
       throw e;
     }
-  }, 0);
+  }, isDev ? 1 : 3);
 
   if (res.status === 'ok') {
     return res.data;
   }
 
   const retriesFailedWarning = new StackAssertionError("Failed to execute transaction despite retries! Falling back to non-transactional execution, which may cause data inconsistency.", { cause: res.error });
-  captureError('maybeTransactionWithRetry', retriesFailedWarning);
-
-  return await fn(prismaClient);
+  if (isDev) {
+    throw retriesFailedWarning;
+  } else {
+    captureError('maybeTransactionWithRetry', retriesFailedWarning);
+    return await fn(prismaClient);
+  }
 }

packages/stack-shared/src/utils/results.tsx

@@ -128,7 +128,7 @@ class RetryError extends AggregateError {
     super(
       errors,
       deindent`
-      Error after retrying ${errors.length} times.
+      Error after ${errors.length} attempts.
       
       ${isAllSame ? deindent`
         Attempts 1-${errors.length}:
@@ -151,17 +151,17 @@ RetryError.prototype.name = "RetryError";
 
 async function retry<T>(
   fn: (attempt: number) => Result<T> | Promise<Result<T>>,
-  retries: number,
+  totalAttempts: number,
   { exponentialDelayBase = 1000 } = {},
 ): Promise<Result<T, RetryError>> {
   const errors: unknown[] = [];
-  for (let i = 0; i < retries; i++) {
+  for (let i = 0; i < totalAttempts; i++) {
     const res = await fn(i);
     if (res.status === "ok") {
       return Result.ok(res.data);
     } else {
       errors.push(res.error);
-      if (i < retries - 1) {
+      if (i < totalAttempts - 1) {
         await wait((Math.random() + 0.5) * exponentialDelayBase * (2 ** i));
       }
     }