CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-13 21:01:21 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Refactor AI query logging to encapsulate error handling within async tasks and improve serialization robustness

Browse Source
This commit is contained in:
Aadesh Kheria 2026-05-05 13:16:47 -07:00
parent 0cedc495d7
commit a087f6b0bd
2 changed files with 58 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/backend/src/app/api/latest/internal/mcp-review/update-correction/route.ts
View File

@ -33,7 +33,7 @@ export const POST = createSmartRouteHandler({
const token = getEnvVariable("STACK_MCP_LOG_TOKEN");
const reviewer = user.display_name ?? user.primary_email ?? user.id;
await callReducerStrict("upsert_qa_from_call", [
token,
body.correlationId,

102
apps/backend/src/lib/ai/loggers/ai-query-logger.ts
View File

@ -108,20 +108,25 @@ export async function logAiQuery(entry: AiQueryLogEntry): Promise<void> {
}
function serializeSteps(steps: ReadonlyArray<StepResult<ToolSet>>): string {
return JSON.stringify(steps.map((step, i) => ({
step: i,
text: step.text || undefined,
toolCalls: step.toolCalls.map(tc => ({
toolName: tc.toolName,
toolCallId: tc.toolCallId,
args: tc.input,
})),
toolResults: step.toolResults.map(tr => ({
toolName: tr.toolName,
toolCallId: tr.toolCallId,
result: truncateLargeToolResult(tr.toolName, tr.output),
})),
})));
try {
return JSON.stringify(steps.map((step, i) => ({
step: i,
text: step.text || undefined,
toolCalls: step.toolCalls.map(tc => ({
toolName: tc.toolName,
toolCallId: tc.toolCallId,
args: tc.input,
})),
toolResults: step.toolResults.map(tr => ({
toolName: tr.toolName,
toolCallId: tr.toolCallId,
result: truncateLargeToolResult(tr.toolName, tr.output),
})),
})));
} catch (e) {
captureError("ai-query-steps-serialize", e);
return JSON.stringify({ _serializationFailed: true, stepCount: steps.length });
}
}
export function logAiQuerySuccess(args: {
@ -134,22 +139,27 @@ export function logAiQuerySuccess(args: {
openrouterGenerationId: string | undefined,
}): void {
const { common, startedAt, steps, text, usage, providerMetadata, openrouterGenerationId } = args;
const rawCost = extractCostFromUsage(usage);
runAsynchronouslyAndWaitUntil(logAiQuery({
...common,
stepsJson: serializeSteps(steps),
finalText: text,
inputTokens: usage.inputTokens ?? undefined,
outputTokens: usage.outputTokens ?? undefined,
cachedInputTokens: extractCachedTokens(providerMetadata),
cacheCreationTokens: usage.inputTokenDetails.cacheWriteTokens ?? undefined,
costUsd: rawCost.costUsd ?? extractOpenRouterCost(providerMetadata),
cacheDiscountUsd: undefined, // backfilled by refineGenerationCost below
openrouterGenerationId,
stepCount: steps.length,
durationMs: BigInt(Math.round(performance.now() - startedAt)),
errorMessage: undefined,
}));
// Build the row inside the async task so any throw (serialization,
// metadata extraction, etc.) is contained by the async boundary instead
// of bubbling up into the user-facing success path.
runAsynchronouslyAndWaitUntil(async () => {
const rawCost = extractCostFromUsage(usage);
await logAiQuery({
...common,
stepsJson: serializeSteps(steps),
finalText: text,
inputTokens: usage.inputTokens ?? undefined,
outputTokens: usage.outputTokens ?? undefined,
cachedInputTokens: extractCachedTokens(providerMetadata),
cacheCreationTokens: usage.inputTokenDetails.cacheWriteTokens ?? undefined,
costUsd: rawCost.costUsd ?? extractOpenRouterCost(providerMetadata),
cacheDiscountUsd: undefined, // backfilled by refineGenerationCost below
openrouterGenerationId,
stepCount: steps.length,
durationMs: BigInt(Math.round(performance.now() - startedAt)),
errorMessage: undefined,
});
});
if (openrouterGenerationId != null) {
runAsynchronouslyAndWaitUntil(refineGenerationCost({
generationId: openrouterGenerationId,
@ -166,19 +176,21 @@ export function logAiQueryFailure(args: {
}): void {
const { common, startedAt, err, partialSteps } = args;
captureError("ai-query-upstream", err);
runAsynchronouslyAndWaitUntil(logAiQuery({
...common,
stepsJson: partialSteps && partialSteps.length > 0 ? serializeSteps(partialSteps) : "[]",
finalText: "",
inputTokens: undefined,
outputTokens: undefined,
cachedInputTokens: undefined,
cacheCreationTokens: undefined,
costUsd: undefined,
cacheDiscountUsd: undefined,
openrouterGenerationId: undefined,
stepCount: partialSteps?.length ?? 0,
durationMs: BigInt(Math.round(performance.now() - startedAt)),
errorMessage: formatErrorForLog(err),
}));
runAsynchronouslyAndWaitUntil(async () => {
await logAiQuery({
...common,
stepsJson: partialSteps && partialSteps.length > 0 ? serializeSteps(partialSteps) : "[]",
finalText: "",
inputTokens: undefined,
outputTokens: undefined,
cachedInputTokens: undefined,
cacheCreationTokens: undefined,
costUsd: undefined,
cacheDiscountUsd: undefined,
openrouterGenerationId: undefined,
stepCount: partialSteps?.length ?? 0,
durationMs: BigInt(Math.round(performance.now() - startedAt)),
errorMessage: formatErrorForLog(err),
});
});
}