CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-13 21:01:21 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Session not found/expired bug fix (#1212)

Browse Source 
When you click on a saved account (like "admin@example.com"), the login
form is automatically submitted. But if you then also click the "Sign
In" button (or click the account a second time), a second login attempt
is sent, even though the first one already completed. The second attempt
then fails because the login session it's trying to use is already gone,
causing the "Session not found" error.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved form submission handling on the login page to prevent
duplicate sign-in attempts from rapid user actions or accidental
double-clicks. The form now ensures only one submission occurs per
session.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
aadesh18 2026-04-02 17:14:06 -07:00 committed by GitHub
parent 1f4497f586
commit 826561c33d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
apps/mock-oauth-server/src/index.ts
View File

@ -211,6 +211,11 @@ const loginTemplateSource = `
// Get the form element to submit later
const form = document.querySelector('form');
if (!form) return;
let submitted = false;
const submitOnce = () => {
if (submitted) return;
form.requestSubmit();
};
// Render the list of stored accounts and add direct submission on click.
const renderStoredAccounts = () => {
@ -237,7 +242,7 @@ const loginTemplateSource = `
card.addEventListener('click', () => {
const selectedEmail = card.getAttribute('data-email') || '';
emailInput.value = selectedEmail;
form.submit();
submitOnce();
});
});
} else {
@ -247,8 +252,12 @@ const loginTemplateSource = `
renderStoredAccounts();
// On form submission, store the email if it's not already stored.
form.addEventListener('submit', () => {
form.addEventListener('submit', (e) => {
if (submitted) {
e.preventDefault();
return;
}
submitted = true;
const email = emailInput.value.trim();
if (email && !storedAccounts.includes(email)) {
storedAccounts.push(email);