CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-19 21:00:40 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Remove server-side User-Agent fallback from analytics batch route

Browse Source
This commit is contained in:
mantrakp04 2026-06-10 14:50:53 -07:00
parent 25d425869e
commit 788ee9368a
1 changed files with 13 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
apps/backend/src/app/api/latest/analytics/events/batch/route.tsx
View File

@ -101,7 +101,7 @@ export const POST = createSmartRouteHandler({
inserted: yupNumber().defined(),
}).defined(),
}),
async handler({ auth, body }, fullReq) {
async handler({ auth, body }) {
if (!auth.tenancy.config.apps.installed["analytics"]?.enabled) {
throw new KnownErrors.AnalyticsNotEnabled();
}
@ -134,41 +134,18 @@ export const POST = createSmartRouteHandler({
const clickhouseClient = getClickhouseAdminClient();
// Server-side fallback: stamp the request's User-Agent into the event data
// blob when the client didn't already include one. This lets the analytics
// overview aggregate device/browser/OS breakdowns even for older clients.
const headerUserAgent = (() => {
const raw = fullReq.headers["user-agent"];
if (Array.isArray(raw)) return raw[0] ?? null;
return (raw as string | undefined) ?? null;
})();
const rows = body.events.map((event) => {
const rawData: unknown = event.data;
const isPlainObject = rawData != null && typeof rawData === "object" && !Array.isArray(rawData);
// Only stamp the fallback User-Agent onto object payloads; preserve any other
// (non-object) data as-is instead of dropping it.
let mergedData: unknown = rawData;
if (isPlainObject) {
const baseData = rawData as Record<string, unknown>;
const existingUa = baseData.user_agent;
mergedData = (existingUa == null || existingUa === "")
? { ...baseData, user_agent: headerUserAgent }
: baseData;
}
return ({
event_type: event.event_type,
event_at: new Date(event.event_at_ms),
data: stripLoneSurrogates(mergedData),
project_id: projectId,
branch_id: branchId,
user_id: userId,
team_id: null,
refresh_token_id: refreshTokenId,
session_replay_id: recentSession?.id ?? null,
session_replay_segment_id: body.session_replay_segment_id,
});
});
const rows = body.events.map((event) => ({
event_type: event.event_type,
event_at: new Date(event.event_at_ms),
data: stripLoneSurrogates(event.data),
project_id: projectId,
branch_id: branchId,
user_id: userId,
team_id: null,
refresh_token_id: refreshTokenId,
session_replay_id: recentSession?.id ?? null,
session_replay_segment_id: body.session_replay_segment_id,
}));
await clickhouseClient.insert({
table: "analytics_internal.events",