CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-04 21:04:37 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

small component ui fix (#1414)

Browse Source 
<!--

Make sure you've read the CONTRIBUTING.md guidelines:
https://github.com/stack-auth/stack-auth/blob/dev/CONTRIBUTING.md

-->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Enhanced CLI authentication confirmation tracking to improve session
persistence and state management during sign-in flows.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
BilalG1 2026-05-06 10:22:58 -07:00 committed by GitHub
parent 24245ae54e
commit 775a3be8cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/template/src/components-page/cli-auth-confirm.test.tsx
View File

@ -171,7 +171,7 @@ describe("useCliAuthConfirmation", () => {
accessToken: "access-token",
refreshToken: "refresh-token",
});
expect(new URL(window.location.href).searchParams.get("confirmed")).toBe("true");
expect(sessionStorage.getItem("stack-cli-auth-confirmed")).toBe("login-code");
expect(sendRequest.mock.calls.map(call => JSON.parse(String(call[1].body)))).toMatchInlineSnapshot(`
[
{

28
packages/template/src/components-page/cli-auth-confirm.tsx
View File

@ -28,10 +28,18 @@ async function completeCliAuthWithRefreshToken(app: StackClientApp, loginCode: s
await ensureCliCompleteOk(result);
}
function markUrlConfirmed() {
const url = new URL(window.location.href);
url.searchParams.set("confirmed", "true");
window.history.replaceState({}, "", url.toString());
const CLI_AUTH_CONFIRMED_KEY = "stack-cli-auth-confirmed";
function markConfirmed(loginCode: string) {
sessionStorage.setItem(CLI_AUTH_CONFIRMED_KEY, loginCode);
}
function isConfirmed(loginCode: string): boolean {
return sessionStorage.getItem(CLI_AUTH_CONFIRMED_KEY) === loginCode;
}
function clearConfirmed() {
sessionStorage.removeItem(CLI_AUTH_CONFIRMED_KEY);
}
function getError(err: unknown): Error {
@ -79,7 +87,7 @@ export function useCliAuthConfirmation(): CliAuthConfirmationState {
});
const [confirmed] = useState(() => {
if (typeof window === 'undefined') return false;
return new URLSearchParams(window.location.search).get("confirmed") === "true";
return loginCode != null && isConfirmed(loginCode);
});
const completeWithCurrentUser = useCallback(async () => {
@ -105,6 +113,7 @@ export function useCliAuthConfirmation(): CliAuthConfirmationState {
setStatus("authorizing");
try {
await completeWithCurrentUser();
clearConfirmed();
setStatus("success");
} catch (err) {
setError(getError(err));
@ -130,6 +139,7 @@ export function useCliAuthConfirmation(): CliAuthConfirmationState {
setStatus("authorizing");
if (user) {
await completeWithCurrentUser();
clearConfirmed();
setStatus("success");
return;
}
@ -158,17 +168,13 @@ export function useCliAuthConfirmation(): CliAuthConfirmationState {
accessToken,
refreshToken,
});
// Only mark the URL as confirmed once the anon session is actually
// bound to the browser; otherwise a failure above would leave a stale
// confirmed=true in the URL and the auto-complete effect would later
// bind the CLI to whichever user happens to be signed in.
markUrlConfirmed();
markConfirmed(loginCode);
setStatus("redirecting");
await app.redirectToSignUp({ replace: true });
return;
}
markUrlConfirmed();
markConfirmed(loginCode);
setStatus("redirecting");
await app.redirectToSignIn({ replace: true });
} catch (err) {